Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions Block: link color conflicts with dark themes #1106

Closed
jeherve opened this issue Dec 20, 2024 · 0 comments · Fixed by #1108
Closed

Reactions Block: link color conflicts with dark themes #1106

jeherve opened this issue Dec 20, 2024 · 0 comments · Fixed by #1108
Assignees
Labels
[Block] Reactions [Feature] Reactions [Focus] Compatibility Ensuring the plugin plays well with other plugins [Pri] Normal Triaged [Type] Bug Something isn't working

Comments

@jeherve
Copy link
Member

jeherve commented Dec 20, 2024

Quick summary

The links added in the Reactions block do not use the link colors defined within a block-based theme, so that can cause some contrast issues:

Image

Maybe they should stick to the theme's color scheme as much as possible, and then offer the core layout customization options if one wants to make any changes?

Steps to reproduce

  1. Start with a site running a block-based theme
  2. Customize your theme to use a dark color scheme
  3. Activate the ActivityPub plugin
  4. Check the look of the Reactions block on your site's frontend

What you expected to happen

I would expect the different elements of the block to match my theme's settings.

What actually happened

In the screenshot above, it shows that links are set to be yellow on my site, yet the reactions label is blue and the reaction item link is white.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Logs or notes

No response

@jeherve jeherve added [Block] Reactions [Feature] Reactions [Focus] Compatibility Ensuring the plugin plays well with other plugins [Pri] Normal [Type] Bug Something isn't working Triaged labels Dec 20, 2024
pfefferle added a commit that referenced this issue Dec 20, 2024
This should fix the interference with the Webmention plugin and fix #1106

Can you maybe test the changes with your theme @jeherve ?
obenland pushed a commit that referenced this issue Dec 20, 2024
This should fix the interference with the Webmention plugin and fix #1106

Can you maybe test the changes with your theme @jeherve ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Reactions [Feature] Reactions [Focus] Compatibility Ensuring the plugin plays well with other plugins [Pri] Normal Triaged [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants