Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack: Support comment management in Calypso #1104

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

Jetpack: Support comment management in Calypso #1104

wants to merge 4 commits into from

Conversation

obenland
Copy link
Member

Fixes peLCyI-uB-p2#comment-492

Proposed changes:

  • Adds callbacks to expose custom comment types to the comment API endpoints that power the Calypso comment screen.

Testing instructions:

image

@obenland obenland requested review from jeherve, mikestottuk and a team December 19, 2024 21:34
@obenland obenland self-assigned this Dec 19, 2024
@github-actions github-actions bot added the [Focus] Compatibility Ensuring the plugin plays well with other plugins label Dec 19, 2024
jeherve
jeherve reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work in my tests on a self-hosted site ; I must be missing something in setting up my site for that review:

image image

@obenland
Copy link
Member Author

@jeherve Is the comment count correct and the comments don't show up? Or does none of it work?

pfefferle
pfefferle previously approved these changes Dec 23, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve left review comments

@pfefferle pfefferle pfefferle approved these changes

@mikestottuk mikestottuk Awaiting requested review from mikestottuk

Assignees

@obenland obenland

Labels
[Feature] Reactions [Focus] Compatibility Ensuring the plugin plays well with other plugins [Pri] Normal [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obenland @pfefferle @jeherve