changelog

Author: akirk

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Improved
 
+* Direct Messages: Test for the user being in the to field
 * Direct Messages: Improve HTML to e-mail text conversion
 
 ## [4.5.1] - 2024-12-18

includes/class-mailer.php

@@ -152,13 +152,13 @@ public static function direct_message( $activity, $user_id ) {
 
 		if (
 			is_activity_public( $activity ) ||
-			! in_array( \get_author_posts_url( $user_id ), $recipients )
+			! in_array( \get_author_posts_url( $user_id ), $recipients, true )
 		) {
 			return;
 		}
 
 		// Only accept messages that have the user in the "to" field.
-		if ( ! in_array( \get_author_posts_url( $user_id ), $activity['to'] ) ) {
+		if ( ! in_array( \get_author_posts_url( $user_id ), $activity['to'], true ) ) {
 			return;
 		}
 

readme.txt

@@ -134,6 +134,7 @@ For reasons of data protection, it is not possible to see the followers of other
 
 = Unreleased =
 
+* Direct Messages: Test for the user being in the to field
 * Improved: HTML to e-mail text conversion
 
 = 4.5.1 =

tests/includes/class-test-mailer.php

@@ -282,7 +282,7 @@ public function direct_message_provider() {
 					'to'     => array( 'https://example.com/followers' ),
 				),
 			),
-			'reply+cc'        => array(
+			'reply+cc'         => array(
 				false,
 				array(
 					'actor'  => 'https://example.com/author',
@@ -311,7 +311,7 @@ public function test_direct_message( $send_email, $activity ) {
 
 		// We need to replace back in the user URL because the user_id is not available in the data provider.
 		$replace = function ( $url ) use ( $user_id ) {
-			if ( $url === 'user_url' ) {
+			if ( 'user_url' === $url ) {
 				return get_author_posts_url( $user_id );
 			}
 			return $url;
@@ -406,7 +406,7 @@ public function test_direct_message_text( $text, $expected ) {
 			'object' => array(
 				'content' => $text,
 			),
-			'to' => array( get_author_posts_url( $user_id ) ),
+			'to'     => array( get_author_posts_url( $user_id ) ),
 		);
 
 		// Mock remote metadata.