Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fee details in order notes show amounts without currency codes. #10006

Closed
brucealdridge opened this issue Dec 20, 2024 · 0 comments · Fixed by #10138
Closed

Fee details in order notes show amounts without currency codes. #10006

brucealdridge opened this issue Dec 20, 2024 · 0 comments · Fixed by #10138
Assignees
@zmaglica
Labels
category: core WC Payments core related issues, where it’s obvious. focus: multi-currency focus: positioning & fees priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Milestone
WooPayments 8.9.0

Comments

@brucealdridge
Copy link
Contributor

brucealdridge commented Dec 20, 2024 •
edited
Loading

Describe the bug

When an order is processed using a different currency that the Account currency, fees are listed in the Order Notes. These fees do not always show the correct currency code.
Image

The correct currency symbol is used (eg € £ ¥) but when both currency symbols are the same it is not clear which currency is in use.

To Reproduce

  1. Ensure multicurrency is enabled, purchase an item using a different currency than the account currency (My store is USD, I purchased in MXN
  2. View the order details.
  3. See the Fee details order note uses both currencies but doesn't specify currency codes.

Expected behavior

Fee details:
1.00 MXN → 0.05 USD: $18.82 USD
- Fee (3.9% + $6.37): -$1.05
+ Fee (3.9% + $6.37 MXN): -$1.05 USD
- ● Base fee: 2.9% + $0.30
+ ● Base fee: 2.9% + $0.30 USD
● Foreign exchange fee: 1%
Net payout: $17.77 USD
@brucealdridge brucealdridge added category: core WC Payments core related issues, where it’s obvious. focus: multi-currency focus: positioning & fees type: bug The issue is a confirmed bug. labels Dec 20, 2024
@pierorocca pierorocca added the priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability label Jan 8, 2025
@zmaglica zmaglica mentioned this issue Jan 13, 2025
Merged
6 tasks
@mgascam mgascam added this to the WooPayments 8.9.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmaglica zmaglica

Labels
category: core WC Payments core related issues, where it’s obvious. focus: multi-currency focus: positioning & fees priority: medium The issue/PR is medium priority—non-critical functionality loss, minimal effect on usability type: bug The issue is a confirmed bug.
Projects
None yet
Milestone
WooPayments 8.9.0
Development

Successfully merging a pull request may close this issue.

Added currency code to fee breakdown when currency symbol is same Automattic/woocommerce-payments
4 participants
@brucealdridge @mgascam @zmaglica @pierorocca