Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Background Color with theme Reverie don't save. #8509

Open
ckmccoy2 opened this issue Dec 6, 2024 · 8 comments
Open

Changes to Background Color with theme Reverie don't save. #8509

ckmccoy2 opened this issue Dec 6, 2024 · 8 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". Needs triage [Platform] Atomic [Platform] Simple [Theme] Reverie

Comments

@ckmccoy2
Copy link

ckmccoy2 commented Dec 6, 2024

Quick summary

User in 9142693-zd reported that when trying to change their background color in Appearance > Editor > Styles, it updated in the Editor, but not on the live site.

Steps to reproduce

  1. Set site theme to Reverie
  2. Go to Appearance > Editor > Styles > Colors > Background and try to change the background color and save.
  3. It will update in the Editor, but not on the live site.

What you expected to happen

The background color on the live site to update.

What actually happened

The live site did not update to reflect the new background color.

Impact

One

Available workarounds?

Yes, updating background color using Palette feature instead of the "Background" color

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

It seems to only affect the background color option, I was able to make changes to text color, button styles, etc and they showed on the live site as expected. I tested this on both simple sites (with a Personal plan) and an atomic site (with hosting features enabled on the Business plan, so this seems specific to the Reverie theme.

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 9142693-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". label Dec 6, 2024
@dsas dsas transferred this issue from Automattic/wp-calypso Dec 6, 2024
@dsas dsas added [Theme] Reverie Needs triage and removed [Type] Bug Something isn't working [Pri] High Needs triage [Platform] Simple [Platform] Atomic [Status] Priority Review Triggered KitKat has been notified of this issue in #dotcom-triage-alerts Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Auto-allocated [Status] Escalated to Product Ambassadors labels Dec 6, 2024
@github-actions github-actions bot added [Platform] Atomic [Platform] Simple Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". labels Dec 6, 2024
@dsas
Copy link
Contributor

dsas commented Dec 6, 2024

It's easy to see how this is confusing, but for it to actually work on Reverie you need to change the colour palette, not the background element
Image

This isn't a dotcom specific thing, I can reproduce locally.

@dsas
Copy link
Contributor

dsas commented Dec 6, 2024

Removed from the Marvel board as Reverie should be a theme team responsibility, i'm unsure who best to cc, any idea @iamtakashi ?

@supernovia
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
There are two places where a background color can be set, and only one works on the live site
Image

📌 ACTIONS

  • Triaged
  • Messaged author

📌 Message to Author
@ckmccoy2 I'm editing to share a workaround, and have updated the user

@supernovia
Copy link

Hah, sorry @dsas I just saw your earlier comment :D

@supernovia supernovia moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Dec 7, 2024
@dsas
Copy link
Contributor

dsas commented Dec 7, 2024

No worries @supernovia your screenshot is much more helpful than mine!

@iamtakashi
Copy link
Contributor

I think the dev has left the company, but the designer was cc @beafialho.

@iamtakashi
Copy link
Contributor

I looked at the theme and saw what was causing the problem. But I'm not sure how to solve it 🤔 The theme has a unique paint texture, and the way it was implemented is causing this issue.

@dsas, when you change the colour of the background element, Gutenberg adds an inline style rule to the body. Do you know if there is a way to add it to a given element (in this case, a pseudo-element .background-overlay::before)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". Needs triage [Platform] Atomic [Platform] Simple [Theme] Reverie
Projects
Development

No branches or pull requests

5 participants