Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Known issues from 2.3 release #6

Open
5 of 6 tasks
oldmud0 opened this issue Sep 12, 2018 · 8 comments
Open
5 of 6 tasks

Known issues from 2.3 release #6

oldmud0 opened this issue Sep 12, 2018 · 8 comments
Labels
bug Something isn't working
Milestone

Comments

@oldmud0
Copy link
Member

oldmud0 commented Sep 12, 2018

These bugs were chosen not to be fixed for the 2.3 release, but they are good bugs to fix for future versions (2.3.1, 2.3.2).

  • Clients still cannot send special Unicode characters, but they can receive them correctly.
  • Shout animations run for longer than the GIF animation length.
  • Preanims sometimes play when they are not supposed to.
  • GoldenLayout panels cannot be dragged around for some reason.
  • The chatbox does not automatically scroll down when not visible.
  • When the game panel is maximized, the viewport should not exceed the size of the game panel.
@oldmud0 oldmud0 added the bug Something isn't working label Sep 12, 2018
@oldmud0 oldmud0 added this to the 2.3.1 milestone Sep 12, 2018
@oldmud0 oldmud0 changed the title Known issues in 2.3 Known issues from 2.3 release Sep 12, 2018
@vintprox
Copy link
Contributor

vintprox commented Jul 15, 2019

Shout animations run for longer than the GIF animation length.

I guess similar is about any preanimation. Because GIFs are subject for rendering process, while timing within script loses this delta (basically asynchronous being tightly hold). I dunno how to help this situation btw...

@oldmud0
Copy link
Member Author

oldmud0 commented Jul 15, 2019

Browsers have no timing guarantees about events, which makes bugfixing for the core engine quite problematic.

@stonedDiscord
Copy link
Member

unicode and goldenlayout panels work

@stonedDiscord
Copy link
Member

is the last point about creating a horizontal scrollbar or exceeding the viewport height

@oldmud0
Copy link
Member Author

oldmud0 commented Mar 21, 2020

Basically the viewport height exceeds the max size of the window because it prioritizes having zero margins left and right over keeping the height within screen size. That shouldn't happen. The behavior should be something like this instead.

@stonedDiscord
Copy link
Member

the chatbox now scrolls correctly

@stonedDiscord
Copy link
Member

shout animations are not gif anymore

@stonedDiscord
Copy link
Member

preanims behave correctly now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants