Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servers are unaware of the pos dropdown until next sent message #889

Open
Crystalwarrior opened this issue Jan 29, 2023 · 6 comments
Open
Labels
enhancement Request for functionality not present wontfix This will not be worked on

Comments

@Crystalwarrior
Copy link
Contributor

Describe the bug
The position dropdown only sets position locally for the next spoken message. The server is unaware of the client pos until that point, which is really annoying when it comes to checking someone's position in /getarea or when trying to view positional evidence (such as defense/prosecution evidence, or room escape positional evidence for servers like KFO)

To reproduce
Steps to reproduce the behavior:

  1. Join a server
  2. Set a pos dropdown
  3. Send a message
  4. Notice it only says "position set to "..."" once you send a message and not before.

Expected behavior
Position is set as soon as the dropdown is changed

@Salanto
Copy link
Contributor

Salanto commented Jan 30, 2023

Dropdown does not send the position until you send a message. Who thought this is desirable default behaviour?

@Salanto Salanto added the enhancement Request for functionality not present label Jan 30, 2023
@in1tiate
Copy link
Member

in1tiate commented Feb 4, 2023

Dropdown does not send the position until you send a message. Who thought this is desirable default behaviour?

This change was deliberate. In the past, scrolling through the pos dropdown would spam the server with position change messages (which at this time were still OOC messages hardcoded to say "/pos") and this would flood the chat very quickly. This change was made by @Crystalwarrior in 2.8.

See #112 (comment)

@Salanto
Copy link
Contributor

Salanto commented Feb 4, 2023

Well, we have a packet to set your position, so we are good to go now!

@Salanto
Copy link
Contributor

Salanto commented Feb 11, 2023

Plottwist : That packet is server only. Fuck this application. Hard. Who thought this was a sane decision.

@stonedDiscord
Copy link
Member

complains about a change he made himself...........
a seperate packet seems to be the best solution for this

@in1tiate in1tiate added the wontfix This will not be worked on label Nov 5, 2023
@collinxchu
Copy link
Contributor

In hindsight, maybe a dropdown list was not the best option for this kind of behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for functionality not present wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants