Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_based_sweep_coverage_path_planner.py last example the region coverage problem #907

Closed
kk-1 opened this issue Sep 18, 2023 · 4 comments

Comments

@kk-1
Copy link

kk-1 commented Sep 18, 2023

Describe the bug
The last region example in the code:
PathPlanning/GridBasedSweepCPP/grid_based_sweep_coverage_path_planner.py

I mean the last example:
ox = [0.0, 20.0, 50.0, 200.0, 130.0, 40.0, 0.0]
oy = [0.0, -80.0, 0.0, 30.0, 60.0, 80.0, 0.0]
resolution = 5.0
planning_animation(ox, oy, resolution)

does not produce complete coverage on my system settings.

Expected behavior
A clear and concise description of what you expected to happen.

The coverage is not like in the animated gif shown:
https://github.com/AtsushiSakai/PythonRoboticsGifs/raw/master/PathPlanning/GridBasedSweepCPP/animation.gif

Screenshots
If applicable, add screenshots to help explain your problem.
Check the following image:

Figure_1

Desktop (please complete the following information):
I used Python 3.10.13 on Linux (opensuse tumbleweed)
numpy 1.25.2
matplotlib 3.6.3
matplotlib-inline 0.1.6
scipy 1.11.1

Can you let me know which python and lib versions works for that example.

Thanks.

@UjjwalPardeshi
Copy link

can you assign me this please

@kk-1
Copy link
Author

kk-1 commented Oct 2, 2023

Further investigation suggests float2integer rounding issue.
Probably different Python/package versions have different precision defaults.

@AtsushiSakai
Copy link
Owner

The latest codes have still this issue? I merged this PR #917

@kk-1
Copy link
Author

kk-1 commented Oct 18, 2023

Thanks it works now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants