Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff method of Annotation has a bug - Not used at this moment #355

Open
qifeng-bai opened this issue Jan 9, 2025 · 0 comments
Open

Diff method of Annotation has a bug - Not used at this moment #355

qifeng-bai opened this issue Jan 9, 2025 · 0 comments
Assignees
@qifeng-bai
Milestone
4.4.0

Comments

@qifeng-bai
Copy link
Contributor

qifeng-bai commented Jan 9, 2025 •
edited
Loading

Diff method for Annotation has not been used when fireWhenNotZero is true. Instead, We use the findNewRecords to find the new Annotations

Ref:#356

1, the logic of comparing user_assertion is not right:

I don't think currentAssertions || previousAssertions can be used to check if they are identical

We should use currentAssertions != previousAssertions

2, Test cases need to be added
@qifeng-bai qifeng-bai added this to the 4.4.0 milestone Jan 9, 2025
@qifeng-bai qifeng-bai self-assigned this Jan 9, 2025
@qifeng-bai qifeng-bai changed the title Diff method of Annotation has a bug Diff method of Annotation has a bug - Not used at this moment Jan 10, 2025
qifeng-bai added a commit that referenced this issue Jan 12, 2025
@qifeng-bai
#355 Fix Annotation service and test cases added
e7c2466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qifeng-bai qifeng-bai

Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

No branches or pull requests
1 participant
@qifeng-bai