Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts failing due to fq column contents #323

Open
kylie-m opened this issue Oct 31, 2024 · 4 comments
Open

Alerts failing due to fq column contents #323

kylie-m opened this issue Oct 31, 2024 · 4 comments
Assignees
Labels
Biosecurity Alerts for biosecurity species

Comments

@kylie-m
Copy link

kylie-m commented Oct 31, 2024

Some production alerts failed in this morning's scheduled run due to the contents of the fq column.

Details of each below:

  1. https://lists.ala.org.au/speciesListItem/list/dr27365 has fq with trailing "AND" at the end that is causing errors.
  2. Errors from this list having "OR OR" in the fq.
  3. On NSW_NPWS_BMB_list, multiple spatialObjects OR’ed together, which is not ideal.

@turley85 after the alerts have finished running today/ @nickdos says it's fine to proceed, are you happy to work through the edits for 1 and 2?

For 3, I can try combining these in QGIS when I'm back at my desk tomorrow, and let you know how it goes in test

@kylie-m kylie-m added the Biosecurity Alerts for biosecurity species label Oct 31, 2024
@turley85
Copy link

turley85 commented Oct 31, 2024

Yep, happy to work through them.

@turley85
Copy link

Ok, made those updates to 1 & 2.

@kylie-m
Copy link
Author

kylie-m commented Nov 28, 2024

Hi @turley85,

Apologies this one took a little longer, I’ve worked through #3 on this ticket and am getting good test results on a test list.

Here’s what I’ve done:

  1. Started with the 5 original spatialObjects
  2. Created new spatialObjects that cover the 7 combinations found in the fq column of the NPWS BMB list
  3. Tested for each: the test URL, and an alert on magpies for that area (Pass)
  4. Created a new list with all 7 new spatial objects. I’ve assigned each spatial object to a unique but commonly-occurring species (“test list shapefiles” dr28737)
  5. Tested the alert for this new combined list - all species are showing up across the expected spatial areas (Pass)
  6. Added the -dr to each fq, as per the BMB list, tested again (Pass)
  Previous fq new spatialObject worked in alert Combined spatialObject URL Test URL
1 spatialObject:9434716 OR spatialObject:9433209 9484551 Y https://spatial.ala.org.au/?pid=9484551 https://biocache.ala.org.au/ws/occurrences/search?q=spatialObject:9484551
2 spatialObject:9434716 OR spatialObject:9433209 OR spatialObject:9443215 9484549 Y https://spatial.ala.org.au/?pid=9484549 https://biocache.ala.org.au/ws/occurrences/search?q=spatialObject:9484549
3 spatialObject:9433203 OR spatialObject:9434716 OR spatialObject:9433209 9484541 Y https://spatial.ala.org.au/?pid=9484541 https://biocache.ala.org.au/ws/occurrences/search?q=spatialObject:9484541
4 spatialObject:9433191 OR spatialObject:9433209 9484537 Y https://spatial.ala.org.au/?pid=9484537 https://biocache.ala.org.au/ws/occurrences/search?q=spatialObject:9484537
5 spatialObject:9433203 OR spatialObject:9433215 9484539 Y https://spatial.ala.org.au/?pid=9484539 https://biocache.ala.org.au/ws/occurrences/search?q=spatialObject:9484539
6 spatialObject:9433191 OR spatialObject:9433203 OR spatialObject:9434716 OR spatialObject:9433209 OR spatialObject:9433215 9484517 Y https://spatial.ala.org.au/?pid=9484517 https://biocache.ala.org.au/ws/occurrences/search?q=spatialObject:9484517
7 spatialObject:9433209 OR spatialObject:9433215 9484543 Y https://spatial.ala.org.au/?pid=9484543 https://biocache.ala.org.au/ws/occurrences/search?q=spatialObject:9484543

I’ve also included a spreadsheet that might be easier to see what’s what, in case that's useful.
https://csiroau.sharepoint.com/:x:/r/sites/AtlasofLivingAustraliaTeams/_layouts/15/Doc2.aspx?action=edit&sourcedoc=%7B1f6fb444-6937-4c5a-92be-462bdf1093e5%7D&wdOrigin=TEAMS-MAGLEV.teamsSdk_ns.rwc&wdExp=TEAMS-TREATMENT&wdhostclicktime=1732775735895&web=1

Could you try out these new spatial objects on your NPWS BMB list and see how it goes?
Let me know if any questions or issues,

@kylie-m
Copy link
Author

kylie-m commented Jan 8, 2025

Hi @turley85, happy new year! For when you're back online, I wanted to follow up to see if this worked for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Biosecurity Alerts for biosecurity species
Projects
None yet
Development

No branches or pull requests

2 participants