From 4020abaeb1c67dd386dfc8f488e6015a1c9dcefb Mon Sep 17 00:00:00 2001
From: Mathias Bynens <mathias@qiwi.be>
Date: Wed, 23 Feb 2011 16:44:17 +0100
Subject: [PATCH] Avoid duplicate IDs for password inputs. Fixes #9.

---
 demo.html                 |  7 +++++--
 jquery.placeholder.js     | 18 +++++++++---------
 jquery.placeholder.min.js |  4 ++--
 3 files changed, 16 insertions(+), 13 deletions(-)

diff --git a/demo.html b/demo.html
index 2a094da..bb93c4f 100644
--- a/demo.html
+++ b/demo.html
@@ -17,13 +17,13 @@
   <h1>HTML5 Placeholder jQuery Plugin</h1>
   <p>Check out <a href="http://github.com/mathiasbynens/Placeholder-jQuery-Plugin">the HTML5 Placeholder jQuery Plugin project page on GitHub</a>.</p>
   <pre><code>$(function() {<br> $('input, textarea').placeholder();<br>});</code></pre>
-  <form action="placeholder" method="get">
+  <form>
    <p><label><code>type=search</code> <input type="search" name="search" placeholder="Search this site…"></label></p>
    <p><label><code>type=text</code> <input type="text" name="name" placeholder="e.g. John Doe"></label></p>
    <p><label><code>type=email</code> <input type="email" name="email" placeholder="e.g. address@example.ext"></label></p>
    <p><label><code>type=url</code> <input type="url" name="url" placeholder="e.g. http://mathiasbynens.be/"></label></p>
    <p><label><code>type=tel</code> <input type="tel" name="tel" placeholder="e.g. +32 472 77 69 88"></label></p>
-   <p><label><code>type=password</code> <input type="password" name="password" placeholder="e.g. h4x0rpr00fz"></label></p>
+   <p><label><code>type=password</code> <input type="password" name="password" placeholder="e.g. hunter2" id="p" class="x"></label></p>
    <p><label><code>textarea</code> <textarea name="message" placeholder="Your message goes here"></textarea></label></p>
    <p><input type="submit" value="type=submit"></p>
   </form>
@@ -31,6 +31,9 @@ <h1>HTML5 Placeholder jQuery Plugin</h1>
   <script src="http://ajax.googleapis.com/ajax/libs/jquery/1/jquery.min.js"></script>
   <script src="jquery.placeholder.js"></script>
   <script>
+   // To test the @id toggling on password inputs in browsers that don’t support changing an input’s @type dynamically (e.g. Firefox 3.6 or IE), uncomment this:
+   // jQuery.fn.hide = function() { return this; }
+   // Then add an @id to the password input and apply some styles to it.
    $(function() {
     // Invoke the plugin
     $('input, textarea').placeholder();
diff --git a/jquery.placeholder.js b/jquery.placeholder.js
index 13e2442..d271882 100644
--- a/jquery.placeholder.js
+++ b/jquery.placeholder.js
@@ -1,5 +1,5 @@
 /*!
- * HTML5 Placeholder jQuery Plugin v1.8.1
+ * HTML5 Placeholder jQuery Plugin v1.8.2
  * @link http://github.com/mathiasbynens/Placeholder-jQuery-Plugin
  * @author Mathias Bynens <http://mathiasbynens.be/>
  */
@@ -39,7 +39,7 @@
 		var $input = $(this);
 		if ($input.val() === $input.attr('placeholder') && $input.hasClass('placeholder')) {
 			if ($input.data('placeholder-password')) {
-				$input.hide().next().show().focus();
+				$input.hide().next().attr('id', $input.removeAttr('id').data('placeholder-id')).show().focus();
 			} else {
 				$input.val('').removeClass('placeholder');
 			}
@@ -50,32 +50,32 @@
 		var $replacement,
 		    $input = $(this),
 		    $origInput = $input,
-		    isInitialized = $input.data('placeholder-init');
-		if ($input.val() === '' || (!isInitialized && $input.val() === $input.attr('placeholder'))) {
+		    id = this.id;
+		if ($input.val() === '') {
 			if ($input.is(':password')) {
 				if (!$input.data('placeholder-textinput')) {
 					try {
 						$replacement = $input.clone().attr({ type: 'text' });
 					} catch(e) {
-						$replacement = $('<input>').attr($.extend(args($input[0]), { type: 'text' }));
+						$replacement = $('<input>').attr($.extend(args(this), { type: 'text' }));
 					}
 					$replacement
 						.removeAttr('name')
+						// We could just use the `.data(obj)` syntax here, but that wouldn’t work in pre-1.4.3 jQueries
 						.data('placeholder-password', true)
+						.data('placeholder-id', id)
 						.bind('focus.placeholder', clearPlaceholder);
 					$input
 						.data('placeholder-textinput', $replacement)
+						.data('placeholder-id', id)
 						.before($replacement);
 				}
-				$input = $input.hide().prev().show();
+				$input = $input.removeAttr('id').hide().prev().attr('id', id).show();
 			}
 			$input.addClass('placeholder').val($input.attr('placeholder'));
 		} else {
 			$input.removeClass('placeholder');
 		}
-		if (!isInitialized) {
- 		$origInput.data('placeholder-init', true);
- 	}
 	}
 
 	$(function() {
diff --git a/jquery.placeholder.min.js b/jquery.placeholder.min.js
index 30d6fed..b38b472 100644
--- a/jquery.placeholder.min.js
+++ b/jquery.placeholder.min.js
@@ -1,6 +1,6 @@
 /*!
- * HTML5 Placeholder jQuery Plugin v1.8.1
+ * HTML5 Placeholder jQuery Plugin v1.8.2
  * @link http://github.com/mathiasbynens/Placeholder-jQuery-Plugin
  * @author Mathias Bynens <http://mathiasbynens.be/>
  */
-(function(f){var e='placeholder' in document.createElement('input'),a='placeholder' in document.createElement('textarea');if(e&&a){f.fn.placeholder=function(){return this};f.fn.placeholder.input=f.fn.placeholder.textarea=true}else{f.fn.placeholder=function(){return this.filter((e?'textarea':':input')+'[placeholder]').bind('focus.placeholder',b).bind('blur.placeholder',d).trigger('blur.placeholder').end()};f.fn.placeholder.input=e;f.fn.placeholder.textarea=a}function c(h){var g={},i=/^jQuery\d+$/;f.each(h.attributes,function(k,j){if(j.specified&&!i.test(j.name)){g[j.name]=j.value}});return g}function b(){var g=f(this);if(g.val()===g.attr('placeholder')&&g.hasClass('placeholder')){if(g.data('placeholder-password')){g.hide().next().show().focus()}else{g.val('').removeClass('placeholder')}}}function d(i){var l,k=f(this),h=k,g=k.data('placeholder-init');if(k.val()===''||(!g&&k.val()===k.attr('placeholder'))){if(k.is(':password')){if(!k.data('placeholder-textinput')){try{l=k.clone().attr({type:'text'})}catch(j){l=f('<input>').attr(f.extend(c(k[0]),{type:'text'}))}l.removeAttr('name').data('placeholder-password',true).bind('focus.placeholder',b);k.data('placeholder-textinput',l).before(l)}k=k.hide().prev().show()}k.addClass('placeholder').val(k.attr('placeholder'))}else{k.removeClass('placeholder')}if(!g){h.data('placeholder-init',true)}}f(function(){f('form').bind('submit.placeholder',function(){var g=f('.placeholder',this).each(b);setTimeout(function(){g.each(d)},10)})});f(window).bind('unload.placeholder',function(){f('.placeholder').val('')})}(jQuery));
\ No newline at end of file
+(function(f){var e='placeholder' in document.createElement('input'),a='placeholder' in document.createElement('textarea');if(e&&a){f.fn.placeholder=function(){return this};f.fn.placeholder.input=f.fn.placeholder.textarea=true}else{f.fn.placeholder=function(){return this.filter((e?'textarea':':input')+'[placeholder]').bind('focus.placeholder',b).bind('blur.placeholder',d).trigger('blur.placeholder').end()};f.fn.placeholder.input=e;f.fn.placeholder.textarea=a}function c(h){var g={},i=/^jQuery\d+$/;f.each(h.attributes,function(k,j){if(j.specified&&!i.test(j.name)){g[j.name]=j.value}});return g}function b(){var g=f(this);if(g.val()===g.attr('placeholder')&&g.hasClass('placeholder')){if(g.data('placeholder-password')){g.hide().next().attr('id',g.removeAttr('id').data('placeholder-id')).show().focus()}else{g.val('').removeClass('placeholder')}}}function d(h){var l,k=f(this),g=k,j=this.id;if(k.val()===''){if(k.is(':password')){if(!k.data('placeholder-textinput')){try{l=k.clone().attr({type:'text'})}catch(i){l=f('<input>').attr(f.extend(c(this),{type:'text'}))}l.removeAttr('name').data('placeholder-password',true).data('placeholder-id',j).bind('focus.placeholder',b);k.data('placeholder-textinput',l).data('placeholder-id',j).before(l)}k=k.removeAttr('id').hide().prev().attr('id',j).show()}k.addClass('placeholder').val(k.attr('placeholder'))}else{k.removeClass('placeholder')}}f(function(){f('form').bind('submit.placeholder',function(){var g=f('.placeholder',this).each(b);setTimeout(function(){g.each(d)},10)})});f(window).bind('unload.placeholder',function(){f('.placeholder').val('')})}(jQuery));
\ No newline at end of file