Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling of items and aborting actions #687

Open
ghost opened this issue May 28, 2020 · 0 comments
Open

handling of items and aborting actions #687

ghost opened this issue May 28, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented May 28, 2020

Expected behaviour

When executing an action involving a vItem resulting in either it getting replaced by another one, removed, or some new added to the inventory, the inventory stuff should only happen after the action is completed. If it's interrupted no inventory action should happen at all.

Actual behaviour

Handling of vItems happens before executing the action resulting in items gets lost or duped when the action is interrupted.

Steps to reproduce the behaviour

  1. By a full fuel canister from any store selling it.
  2. Drive a car until its fule tank starts to drain.
  3. Refuel the car by using the full fuel canister.
  4. While refueling move usng WASD.
  5. The refueling action is interrupted.
  6. Look at your virtual inventory: The fuel canister is lost.

RPT and/or extDB3 logs (if applicable)

not applicable

Mission version: 6.0.0
Launcher version: 1.5.146373
Game version: 1.98.146373
Branch: main / beta branch not specified

I spotted this problem while I was testing #685 and tried to figure out the interruption. As I had to first somehow get an empty canister I drove a car and refueld it. I wanted to see if this is a general issue with how vItems are handled so I moved during the refueling - which ended up in the full fuel canister got lost. As this seem to not only affect the full and empty fuel canister while refuling but maybe any vItems and any action involving them this seem like an overall issue about the order of execution.

@ghost ghost closed this as completed May 29, 2020
@BoGuu BoGuu reopened this May 29, 2020
Edward-Bakker added a commit to Edward-Bakker/Framework that referenced this issue Jun 1, 2020
DomT602 pushed a commit that referenced this issue Jun 2, 2020
@Edward-Bakker Edward-Bakker mentioned this issue Jun 6, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant