Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WaterSystems instantiated into other scenes do not work correctly #6

Open
Arnklit opened this issue Jan 12, 2021 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@Arnklit
Copy link
Owner

Arnklit commented Jan 12, 2021

Describe the bug
If a WaterSystem is instantiated into another scene, it might not be at the same coordinates and therefore the coordinates used for the height and flow maps are no longer valid. This will also cause issues with the auto assign of the textures and coordinates for use in Custom shaders as this happens on texture generation and therefore will only work withing the local scene.

Expected behavior
Have the node calculate an offset to the coordinates based on it's world position at run time. Also have the auto assign happen on enter_tree / ready as well as on generate.

@Arnklit Arnklit self-assigned this Jan 30, 2021
@Arnklit Arnklit added the bug Something isn't working label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant