Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect FQDN Settings of pfSense Telegraf Plugin #4

Open
zeus86 opened this issue Jun 6, 2021 · 2 comments
Open

Respect FQDN Settings of pfSense Telegraf Plugin #4

zeus86 opened this issue Jun 6, 2021 · 2 comments

Comments

@zeus86
Copy link
Contributor

zeus86 commented Jun 6, 2021

The Hostname of the pfSense (in terms of "how this host is Named in the DB") is currently constructed like so:
self.pfSense_host = self.pfSense_config['system']['hostname'] + "." + self.pfSense_config['system']['domain']
It takes the base hostname and appends the domainname. If you already have some basic metric collection going with pfsense and telegraf, it is plugin-configurable if either the short-hostname or the FQDN should be utilized. With the shortname (which I prefer) you'll end up with two host entries in the DB, one with and one without the Domain appended.

pfsense-to-influxdb should either respect the value as how it is configured in the pfSense telegraf-plugin or have it at least configurable throught the pfsense-to-influx-settings.

@ArmaanT
Copy link
Owner

ArmaanT commented Jun 6, 2021

For the sake of backward compatibility, I think making that hostname configurable with the default value being the current form would be the best option. I'd be happy to merge a PR with those changes.

@zeus86
Copy link
Contributor Author

zeus86 commented Jun 7, 2021

I think I'll do exactly this, but this will last a few days, too many other things on the todo still...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants