Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Value can never 1 #35

Open
Satokaheni opened this issue Jul 19, 2019 · 2 comments
Open

Value can never 1 #35

Satokaheni opened this issue Jul 19, 2019 · 2 comments

Comments

@Satokaheni
Copy link

Line 116 of funcs.py I'm not sure value can ever be 1 based on how you've defined it in game.py. Based on game.py function _getValue it can only ever be -1 or 0.
@KUEE1080
Copy link

I also think value can never be 1. Has anyone fixed this issue?

@hccho2
Copy link

hccho2 commented Jan 13, 2020 •
edited
Loading

If the game is over on your turn, you lost the game because the game was over by the action immediately before it.

So value is always -1.

It is not a bug, but the codes for value=1 are redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Satokaheni @KUEE1080 @hccho2