refactor: Replaced some iterators based loops with range-based ones

Author: pktiuk

src/autoprofilewatcher.cpp

@@ -26,9 +26,6 @@
 #include <QDir>
 #include <QFile>
 #include <QFileInfo>
-#include <QListIterator>
-#include <QSetIterator>
-#include <QStringListIterator>
 
 #if defined(Q_OS_UNIX) && defined(WITH_X11)
     #include "x11extras.h"
@@ -213,11 +210,8 @@ void AutoProfileWatcher::runAppCheck()
 
                 bool hasOnePartName = false;
 
-                QListIterator<AutoProfileInfo *> iterList(iter.value());
-                while (iterList.hasNext())
+                for (auto autoInfo : iter.value())
                 {
-                    AutoProfileInfo *autoInfo = iterList.next();
-
                     if (autoInfo->isPartialState())
                     {
                         hasOnePartName = true;
@@ -275,10 +269,8 @@ void AutoProfileWatcher::runAppCheck()
         QHash<QString, int> highestMatchCount;
         QHash<QString, AutoProfileInfo *> highestMatches;
 
-        QSetIterator<AutoProfileInfo *> fullSetIter(fullSet);
-        while (fullSetIter.hasNext())
+        for (auto &&info : fullSet)
         {
-            AutoProfileInfo *info = fullSetIter.next();
             if (info->isActive())
             {
                 int numProps = 0;
@@ -317,11 +309,8 @@ void AutoProfileWatcher::runAppCheck()
             }
         }
 
-        QHashIterator<QString, AutoProfileInfo *> highIter(highestMatches);
-
-        while (highIter.hasNext())
+        for (auto &&info : highestMatches)
         {
-            AutoProfileInfo *info = highIter.next().value();
             getUniqeIDSetLocal().insert(info->getUniqueID());
             emit foundApplicableProfile(info);
         }
@@ -333,13 +322,8 @@ void AutoProfileWatcher::runAppCheck()
                 emit foundApplicableProfile(allDefaultInfo);
             }
 
-            QHashIterator<QString, AutoProfileInfo *> iter(getDefaultProfileAssignments());
-
-            while (iter.hasNext())
+            for (auto &&info : getDefaultProfileAssignments())
             {
-                iter.next();
-                AutoProfileInfo *info = iter.value();
-
                 if (info->isActive() && !getUniqeIDSetLocal().contains(info->getUniqueID()))
                 {
                     emit foundApplicableProfile(info);
@@ -381,11 +365,8 @@ void AutoProfileWatcher::syncProfileAssignment()
     }
 
     // Handle device specific Default profile assignments
-    QStringListIterator iter(registeredUniques);
-
-    while (iter.hasNext())
+    for (auto &&tempkey : registeredUniques)
     {
-        QString tempkey = iter.next();
         QString uniqueID = QString(tempkey).replace("UniqueID", "");
         QString profile = settings->value(QString("DefaultAutoProfile-%1/Profile").arg(uniqueID), "").toString();
         QString active = settings->value(QString("DefaultAutoProfile-%1/Active").arg(uniqueID), "").toString();
@@ -529,65 +510,51 @@ void AutoProfileWatcher::syncProfileAssignment()
 void AutoProfileWatcher::clearProfileAssignments()
 {
     QSet<AutoProfileInfo *> terminateProfiles;
-    QListIterator<QList<AutoProfileInfo *>> iterDelete(appProfileAssignments.values());
 
-    while (iterDelete.hasNext())
+    for (const auto &profileList : appProfileAssignments.values())
     {
-        QList<AutoProfileInfo *> templist = iterDelete.next();
 #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
-        terminateProfiles.unite(QSet<AutoProfileInfo *>(templist.begin(), templist.end()));
+        terminateProfiles.unite(QSet<AutoProfileInfo *>(profileList.begin(), profileList.end()));
 #else
-        terminateProfiles.unite(templist.toSet());
+        terminateProfiles.unite(profileList.toSet());
 #endif
     }
 
     appProfileAssignments.clear();
 
-    QListIterator<QList<AutoProfileInfo *>> iterClassDelete(windowClassProfileAssignments.values());
-
-    while (iterClassDelete.hasNext())
+    for (const auto &profileList : windowClassProfileAssignments.values())
     {
-        QList<AutoProfileInfo *> templist = iterClassDelete.next();
 #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
-        terminateProfiles.unite(QSet<AutoProfileInfo *>(templist.begin(), templist.end()));
+        terminateProfiles.unite(QSet<AutoProfileInfo *>(profileList.begin(), profileList.end()));
 #else
-        terminateProfiles.unite(templist.toSet());
+        terminateProfiles.unite(profileList.toSet());
 #endif
     }
 
     windowClassProfileAssignments.clear();
 
-    QListIterator<QList<AutoProfileInfo *>> iterNameDelete(windowNameProfileAssignments.values());
-
-    while (iterNameDelete.hasNext())
+    for (const auto &profileList : windowNameProfileAssignments.values())
     {
-        QList<AutoProfileInfo *> templist = iterNameDelete.next();
 #if QT_VERSION >= QT_VERSION_CHECK(5, 14, 0)
-        terminateProfiles.unite(QSet<AutoProfileInfo *>(templist.begin(), templist.end()));
+        terminateProfiles.unite(QSet<AutoProfileInfo *>(profileList.begin(), profileList.end()));
 #else
-        terminateProfiles.unite(templist.toSet());
+        terminateProfiles.unite(profileList.toSet());
 #endif
     }
 
     windowNameProfileAssignments.clear();
 
-    QSetIterator<AutoProfileInfo *> iterTerminate(terminateProfiles);
-
-    while (iterTerminate.hasNext())
+    for (auto *info : terminateProfiles)
     {
-        AutoProfileInfo *info = iterTerminate.next();
         if (info != nullptr)
         {
             info->deleteLater();
             info = nullptr;
         }
     }
 
-    QListIterator<AutoProfileInfo *> iterDefaultsDelete(getDefaultProfileAssignments().values());
-
-    while (iterDefaultsDelete.hasNext())
+    for (auto *info : getDefaultProfileAssignments().values())
     {
-        AutoProfileInfo *info = iterDefaultsDelete.next();
         if (info != nullptr)
         {
             info->deleteLater();

src/joybuttonmousehelper.cpp

@@ -100,11 +100,9 @@ void JoyButtonMouseHelper::mouseEvent()
 void JoyButtonMouseHelper::resetButtonMouseDistances()
 {
     QList<JoyButton *> *buttonList = JoyButton::getPendingMouseButtons();
-    QListIterator<JoyButton *> iter(*buttonList);
 
-    while (iter.hasNext())
+    for (JoyButton *temp : *buttonList)
     {
-        JoyButton *temp = iter.next();
         temp->resetAccelerationDistances();
     }
 }

src/sdleventreader.cpp

@@ -29,7 +29,6 @@
 #include <QDebug>
 #include <QMapIterator>
 #include <QSettings>
-#include <QStringListIterator>
 #include <QVariant>
 
 SDLEventReader::SDLEventReader(QMap<SDL_JoystickID, InputDevice *> *joysticks, AntiMicroSettings *settings, QObject *parent)
@@ -77,11 +76,9 @@ void SDLEventReader::initSDL()
     settings->getLock()->lock();
     settings->beginGroup("Mappings");
     QStringList mappings = settings->allKeys();
-    QStringListIterator iter(mappings);
 
-    while (iter.hasNext())
+    for (auto &&tempstring : mappings)
     {
-        QString tempstring = iter.next();
         QString mappingSetting = settings->value(tempstring, QString()).toString();
 
         if (!mappingSetting.isEmpty())