Skip to content
This repository has been archived by the owner on Jul 15, 2024. It is now read-only.

Add configuration change, to prevent state loss #2

Open
wax911 opened this issue Dec 27, 2019 · 0 comments
Open

Add configuration change, to prevent state loss #2

wax911 opened this issue Dec 27, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@wax911
Copy link
Member

wax911 commented Dec 27, 2019

Issue Guidelines

Before opening a new issue, please take a moment to review our community guidelines to make the contribution process easy and effective for everyone involved.

You may find an answer in already closed issues:
https://github.com/anitrend/material-multi-search/issues?q=is%3Aissue+is%3Aclosed

Feature Information

Current the library will clear all search items when the device configuration is changed. It would be handy to have some sort of saved instance state when this happens so that the library retains state in such cases.

Solution Information

We could use override onSaveInstanceState and onRestoreInstanceState in our MutliSearch class, in addition to this we might need to introduce a data class to hold information about search terms and last selected index (this would be what we will put in bundles) which we would use to restore state from

@wax911 wax911 added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 27, 2019
@wax911 wax911 added this to the v0.2.0 milestone Dec 27, 2019
@wax911 wax911 self-assigned this Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant