Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converter skips some html elements #8

Open
arabesc opened this issue Jun 26, 2016 · 3 comments
Open

Converter skips some html elements #8

arabesc opened this issue Jun 26, 2016 · 3 comments
Labels
Milestone

Comments

@arabesc
Copy link

arabesc commented Jun 26, 2016

E.g., example.com##div[class^="some_text"] wouldn't be handled.

@Andrwe Andrwe added this to the version 0.5 milestone Mar 19, 2022
@Andrwe
Copy link
Owner

Andrwe commented Jan 10, 2024

Thank you for reporting, I'll check adding a handler for HTML elements for version 0.5.

@Andrwe Andrwe added bug and removed enhancement labels Jan 17, 2024
@Andrwe Andrwe modified the milestones: version 0.5, version 0.4 Jan 17, 2024
@Andrwe
Copy link
Owner

Andrwe commented Jan 17, 2024

I checked the current implementation and it is broken because * does not match all requests anymore.

I'm implementing a fix in https://github.com/Andrwe/privoxy-blocklist/tree/check_privoxy_runtime_logs.

This might take some time because during my tests I found the content filter to slowdown request processing of Privoxy by up to minutes. One test case took ~4 minutes until the response was received by the client.
So far my tests show that the slowdown is impacted by the amount of patterns per applying filter and the size of the requested page.

Therefore I'm working on some optimization and a configuration option to en-/disable content filtering.

@Andrwe
Copy link
Owner

Andrwe commented Jan 28, 2024

With #48 HTML elements with global scope will be filtered when enabled in configuration file.

Other scopes (domain-based & HTML-tag-based) will be implemented in later versions.

@Andrwe Andrwe modified the milestones: version 0.4, version 0.5 Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants