This repository has been archived by the owner on Jan 7, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Valid issues outside of diff view #135
Comments
This is a duplicate of #34, I am closing the other one as this ticket describes the problem better. |
We have some choices:
Personally I am in favour of 4) |
I have created a pull request #137. In my solution I decided to add a comment to the top of the file and in comment say precisely in which line issue is. Aditionally this comment is visible in overview but it is not linked with specific line so I added information about a file where issue is located. This path is also a hyperlink. |
@mdanielak Can you take a look at #161? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From time to time there is a situation in pull requests when issues appear outside of diff view and comment cannot be added. It happens because bitbucket allows only adding comments in +/- 10 lines from changes lines.
For instance we have multiple files in pull request with many classes and methods. In this pull request there is a method myMethod() declared in line 50. Author adds few if conditions in line 100 and below. After analysis Sonarqube says
The Cyclomatic Complexity of this class is 201 which is greater than 200 authorized.
And comment can't be added because of the diff lines bitbucket limitation.
The same situation can happen with other type of issues like unused imports, consider using constaints instead of duplicating literals, etc
If there are a lot of files, classes and methods in the pull request author is confused and doesn't know where is the problem.
Have you faced this issue before? Are there any plans to handle it?
Thank you
The text was updated successfully, but these errors were encountered: