feat(training): loading progress indicator #2499
Open
+125
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 96e543d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
fpaul-1A
force-pushed
the
feat/otter-training-loading-progress
branch
from
e1d1c83
to
c499e32
Compare
fpaul-1A
changed the title
fpaul-1A
force-pushed
the
feat/otter-training-loading-progress
branch
from
c499e32
to
96e543d
Compare
kpanot
approved these changes
Nov 22, 2024
| @@ -147,10 +174,35 @@ export class WebContainerRunner { | |||
| const process = await instance.spawn(command, args, {cwd: cwd}); | |||
| this.commandOutput.process.next(process); | |||
| const exitCode = await process.exit; | |||
| if (exitCode !== 0) { | |||
| if (exitCode === 0) { | |||
There was a problem hiding this comment.
Shouldn't we prefer a switch case, in case we have to handle others exitCode or it should never happen ?
matthieu-crouzet
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
https://fpaul-1a.github.io/otter/#/sdk-training#1
Related issues
- No issue associated -