feat: otter sdk training - how to use the otter sdk #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
07f2aaf
to
fa63274
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d544e8d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
fpaul-1A
reviewed
Nov 20, 2024
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Nov 20, 2024
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/solution/app.component.ts
Outdated
Show resolved
Hide resolved
fpaul-1A
reviewed
Nov 20, 2024
Comment on lines
15
to
30
| const localStorageStates: Record<string, Serializer<any>>[] = [/* Store to register in local storage */]; | ||
| const storageSync = new StorageSync({ | ||
| keys: localStorageStates, rehydrate: true | ||
| }); | ||
|
|
||
| const rootReducers = {}; | ||
|
|
||
| const metaReducers = [storageSync.localStorageSync()]; | ||
| const runtimeChecks: Partial<RuntimeChecks> = { | ||
| strictActionImmutability: false, | ||
| strictActionSerializability: false, | ||
| strictActionTypeUniqueness: !environment.production, | ||
| strictActionWithinNgZone: !environment.production, | ||
| strictStateImmutability: !environment.production, | ||
| strictStateSerializability: false | ||
| }; |
There was a problem hiding this comment.
we should remove all the @ngrx stuff, it's adding a lot of noise and is not the relevant for the sdk training
There was a problem hiding this comment.
I cleaned up the app.config.ts file, but I left the @ngrx dependencies in the package.json files since some are peer dependencies for other packages. What do you think?
There was a problem hiding this comment.
we are already installing using --legacy-peer-deps so I don't think the warnings will matter
there is no reason for @ngrx to be used in the training so we can safely remove the dependency
kpanot
reviewed
Nov 20, 2024
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.ts
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/solution/app.component.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
reviewed
Nov 21, 2024
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/instructions.md
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
fa63274
to
97cfa4c
Compare
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.html
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.html
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/solution/app.config.ts
Outdated
Show resolved
Hide resolved
apps/showcase/src/assets/trainings/sdk/steps/typescript-sdk/exercise/app.component.ts
Outdated
Show resolved
Hide resolved
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
97cfa4c
to
b46170a
Compare
fpaul-1A
reviewed
Nov 22, 2024
sdo-1A
force-pushed
the
feat/training-sdk-how-to-use
branch
from
b46170a
to
d544e8d
Compare
kpanot
reviewed
Nov 22, 2024
| "options": { | ||
| "script": "extract" | ||
| }, | ||
| "inputs": [ |
There was a problem hiding this comment.
The following file seems missing {projectRoot}/openapitools.json
(if not already part of source)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
How to use the Otter SDK step
The goal is for the user to create a fetch client and use the pet API to display the results in the UI
Related issues
- No issue associated -