-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): renamed exported recommended #2354
base: main
Are you sure you want to change the base?
Conversation
packages/@o3r/eslint-plugin/schematics/ng-update/v11/update-configs/update-configs.ts
Outdated
Show resolved
Hide resolved
packages/@o3r/eslint-plugin/schematics/ng-update/v11/update-configs/update-configs.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we do the same ng-update for the @o3r/eslint-config-otter
as the ng-add of @o3r/eslint-plugin
does nothing but @o3r/eslint-config-otter
does the setup
and in @o3r/eslint-config-otter
we should migrate to the not deprecated configs
Moreover do we really need this fix right now as we are working on the ESLint flat config ? or could it be done directly inside the branch for this migration to flat config ?
f475e20
to
ff81804
Compare
Indeed, due to technically limitation (fake recursive ref to
Nothing requires to have the flat config to fix the exposed recommended. |
ff81804
to
b16c2d2
Compare
b16c2d2
to
d4ba8b1
Compare
453d446
to
0f0c36a
Compare
...es/@o3r/eslint-config-otter/schematics/ng-update/v11.4/update-configs/update-configs.spec.ts
Outdated
Show resolved
Hide resolved
0f0c36a
to
840dd69
Compare
'json-recommended': { | ||
rules: { | ||
'@o3r/json-dependency-versions-harmonize': 'error' | ||
} | ||
}, | ||
|
||
'angular-template-recommended': { | ||
rules: { | ||
'@o3r/no-inner-html': 'off', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
off
is the recommended value for this rule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is the current value.
It can be changed, in the big eslint refactor if we want
840dd69
to
e8cf18b
Compare
packages/@o3r/eslint-config-otter/schematics/ng-update/index.ts
Outdated
Show resolved
Hide resolved
e8cf18b
to
ca7ae3f
Compare
ca7ae3f
to
5100e62
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
5100e62
to
28087e4
Compare
fix(eslint-plugin): turn yaml parser really optional
deprecate(eslint-plugin): recommended exports based on types
Proposed change
feat(eslint-plugin): renamed exported recommended
fix(eslint-plugin): turn yaml parser really optional
deprecate(eslint-plugin): recommended exports based on types
Related issues