-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: The tsconfig spec generated for library contains several issues #2481
Labels
Comments
Issue referenced in |
cpaulve-1A
added a commit
that referenced
this issue
Dec 12, 2024
…2481 Align with application generation and reuse angular tsconfig.spec.json
cpaulve-1A
added a commit
that referenced
this issue
Dec 13, 2024
…2481 Align with application generation and reuse angular tsconfig.spec.json
cpaulve-1A
added a commit
that referenced
this issue
Dec 16, 2024
…2481 Align with application generation and reuse angular tsconfig.spec.json
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 27, 2025
…2584) ## Proposed change Only use composite for library generated for workspace set up with jest. Ensure path do not target any invalid files. ## Related issues * 🐛 Fix #2481 <!-- * 🐛 Fix resolves #issue --> <!-- * 🚀 Feature #issue --> <!-- * 🚀 Feature resolves #issue --> <!-- *Pull Request #issue -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Package name
workspace
Package version
11.4.1
Reproduction steps
To reproduce the issue you can run the following commands:
npm create @o3r monorepo cd monorepo npm run ng g @o3r/workspace:library lib
If you try to run
npm run ng test lib
You will have errors because of issues in the
libs/lib/tsconfig.spec.json
Current result
libs/lib/tsconfig.spec.json
content is the following:but
libs/lib/tsconfig.build.composite.json
does not exist.Expected result
libs/lib/tsconfig.spec.json
should contain only relevant references.Running
npm run ng test lib
should works fine.Additional comments
It seems that IDE is complaining also on the
composite
, to be checked why.The library is generated with jest for testing but
"types": ["jest"]
is missing in thelibs/lib/tsconfig.spec.json#compilerOptions
The text was updated successfully, but these errors were encountered: