Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross-dependency between test projects #916

Open
danielskovli opened this issue Nov 20, 2024 · 1 comment
Open

Fix cross-dependency between test projects #916

danielskovli opened this issue Nov 20, 2024 · 1 comment
Labels
good-first-issue Issues that are easy to fix for new team members or external contributors kind/chore status/triage

Comments

@danielskovli
Copy link
Contributor

Description

During #897, for whatever reason, I needed access to something from Altinn.App.Api.Tests in Altinn.App.Core.Test: https://github.com/Altinn/app-lib-dotnet/pull/897/files#diff-368dd4a3905e2ad7d20facda4de7250f66ca9addd8cbaab95bd6f43a3ce602adR34

Refactoring around this requirement felt like a bitter and time consuming pill to swallow at the time.

At some glorious point in the future, this should be fixed.

Additional Information

I cant remember exactly what the dependency was, but simply removing the reference in Altinn.App.Api.Tests.csproj` and trying to compile the tests will probably give a good indication of what's up.

Tasks

No response

Acceptance Criterias

No response

@danielskovli danielskovli added good-first-issue Issues that are easy to fix for new team members or external contributors kind/chore labels Nov 20, 2024
@danielskovli danielskovli mentioned this issue Nov 20, 2024
5 tasks
@danielskovli
Copy link
Contributor Author

Note to self: This test should have been placed in the Altinn.App.Core.Tests project, but had to be placed in the Altinn.App.Api.Tests project because it relies on some test data which is located there.

Perhaps test data should be moved to the Altinn.App.Common.Tests project, along with lots of other things I'm sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Issues that are easy to fix for new team members or external contributors kind/chore status/triage
Projects
Status: No status
Development

No branches or pull requests

1 participant