Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tilbakemelding på MessageBody #463

Closed
3 tasks done
Andreass2 opened this issue Nov 8, 2024 · 4 comments
Closed
3 tasks done

Tilbakemelding på MessageBody #463

Andreass2 opened this issue Nov 8, 2024 · 4 comments
Assignees
@mSunberg
Labels
kind/bug Something isn't working kind/question Questions raised should be labeled with this. product/meldingstjenesten Issues related to Altinn Correspondence

Comments

@Andreass2
Copy link
Collaborator

Andreass2 commented Nov 8, 2024 •
edited by mSunberg
Loading

Det har kommet tilbakemelding på hvordan en melding ser ut i AF.
Utseende:
Image
Sendt til correspondence:
Image

  • Meldingen viser anførselstegn i arbeidsflate. Undersøk om feilen ligger hos oss eller hos de.
  • Skal vi støtte /n for newline. Per nå blir det ikke newline. Her må vi høre med AF
  • Oppdater Daniel Skovli på resultatene på spørsmålene over
@Andreass2 Andreass2 converted this from a draft issue Nov 8, 2024
@Andreass2 Andreass2 added kind/bug Something isn't working kind/question Questions raised should be labeled with this. product/meldingstjenesten Issues related to Altinn Correspondence labels Nov 8, 2024
@mSunberg mSunberg self-assigned this Nov 13, 2024
@mSunberg mSunberg moved this from Ready for dev to 🏗 In progress in Altinn melding og formidling Nov 13, 2024
@mSunberg mSunberg mentioned this issue Nov 15, 2024
Closed
@mSunberg
Copy link
Collaborator

Får ikke testet messagebody før denne er klar:
Altinn/dialogporten#1458

@mSunberg
Copy link
Collaborator

Avklart med AF, det må støttes linjeskift, men det må følge common mark-spesifikasjonene: https://spec.commonmark.org/0.31.2/#hard-line-breaks

@leogasnier
Copy link

denne er val avblokka nå @mSunberg

@ToreMasoy ToreMasoy moved this from 🏗 In progress to 📋 Backlog in Altinn melding og formidling Nov 25, 2024
@ToreMasoy ToreMasoy removed the blocked label Nov 25, 2024
@ToreMasoy ToreMasoy moved this from 📋 Backlog to Ready for dev in Altinn melding og formidling Nov 25, 2024
@mSunberg
Copy link
Collaborator

Har sett nærmere på messageBody nå.
Respons-typen vi bruker i API-et er:
application/vnd.dialogporten.frontchannelembed+json;type=markdown; charset=utf-8

Jeg tror det gir mer mening at AF formaterer vekk anførselstegn fra responsen enn at vi endrer på API´et siden det er standard json å returnere en streng med anførselstegn.

@mSunberg mSunberg mentioned this issue Nov 26, 2024
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Altinn melding og formidling Nov 27, 2024
@danielskovli danielskovli mentioned this issue Jan 17, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mSunberg mSunberg

Labels
kind/bug Something isn't working kind/question Questions raised should be labeled with this. product/meldingstjenesten Issues related to Altinn Correspondence
Projects
Altinn melding og formidling
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Andreass2 @ToreMasoy @leogasnier @mSunberg