Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a IdbCursorWithValue::into_vec_values #39

Closed
FirelightFlagboy opened this issue Jul 30, 2024 · 3 comments
Closed

Provide a IdbCursorWithValue::into_vec_values #39

FirelightFlagboy opened this issue Jul 30, 2024 · 3 comments
Assignees
Labels
Released This issue's resolution is now available in a published release

Comments

@FirelightFlagboy
Copy link

Currently IdbCursorWithValue provide into_vec method that return a Vec containing the Key-Value pair.

I would like to have something similar that only return the value.
Given the implentation of into_vec it seems doable to have something that return directly the self.value() in the mapper of handle_into_vec.

If it's fine for you, I could provide a PR

@Alorel
Copy link
Owner

Alorel commented Jul 31, 2024

Hey, I'm currently rewriting a lot of the crate so I'd avoid making new PRs in the meantime - I'll just take this into account when the PR for that is finally up. I only quickly glanced over the issue and source code just now so might be missing the mark here, but I think the issue might end up just getting closed as part of the redesign.

State of the library now:

  • Essentially just turns Javascript requests with success/error events into Rust futures
  • Still largely working with JS types
  • Still feels like Rust bindings for a JS API

State I intend:

  • Feels like an API written in and designed for Rust
  • JS types only really exposed in catch-all type errors
  • Integrates with serde for storing/reading objects instead of JS primitives
  • Better integration with the Rust ecosystem, e.g. implementing streams for cursors

@Alorel
Copy link
Owner

Alorel commented Oct 27, 2024

@FirelightFlagboy Your request will be getting implemented indirectly - #40 is getting merged in the next couple of days unless I spot something horribly wrong and, with it, cursors will implement Stream and, by extension, TryStreamExt - it'll allow you to do any sort of manipulation you need.

Alorel added a commit that referenced this issue Oct 27, 2024
Closes #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
@Alorel Alorel self-assigned this Oct 27, 2024
Alorel added a commit that referenced this issue Oct 27, 2024
Closes #25, #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
Alorel added a commit that referenced this issue Oct 27, 2024
Closes #25, #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
Alorel added a commit that referenced this issue Oct 27, 2024
Closes #25, #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
Alorel added a commit that referenced this issue Oct 27, 2024
Closes #25, #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
Alorel added a commit that referenced this issue Oct 27, 2024
Closes #25, #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
Alorel added a commit that referenced this issue Oct 27, 2024
Closes #25, #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
Alorel added a commit that referenced this issue Oct 27, 2024
Closes #25, #32, #39

BREAKING CHANGE: API redesigned for serde & Stream support & msrv bumped to 1.75. See [MIGRATING/v0.6.0.md](https://github.com/Alorel/rust-indexed-db/blob/v0.6.0/MIGRATING/v0.6.0.md) for details.
@Alorel Alorel closed this as completed Oct 27, 2024
@Alorel Alorel added the Released This issue's resolution is now available in a published release label Oct 27, 2024
@Alorel
Copy link
Owner

Alorel commented Oct 27, 2024

This issue has been included in v0.6.0 🎉

- Your friendly neighbourhood 🤖 semantic release bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released This issue's resolution is now available in a published release
Projects
None yet
Development

No branches or pull requests

2 participants