Skip to content

Commit 9639f52

Browse files
committed
Updated dependencies and lowered min sdk version
1 parent 2b26769 commit 9639f52

File tree

11 files changed

+35
-74
lines changed

11 files changed

+35
-74
lines changed

build.gradle.kts

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,16 @@
11
import java.net.URI
22

3-
// Top-level build file where you can add configuration options common to all sub-projects/modules.
3+
plugins {
4+
id("com.github.ben-manes.versions") version "0.27.0"
5+
}
46

57
buildscript {
68
repositories {
79
google()
810
jcenter()
911
}
1012
dependencies {
11-
classpath("com.android.tools.build:gradle:3.3.0")
13+
classpath("com.android.tools.build:gradle:3.5.3")
1214
classpath(kotlin("gradle-plugin", version = Versions.kotlin))
1315
classpath("com.github.dcendents:android-maven-gradle-plugin:2.1")
1416

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
object AndroidConfig {
2-
const val compileSdkVersion = 28
2+
const val compileSdkVersion = 29
33
const val targetSdkVersion = compileSdkVersion
4-
const val minSdkVersion = 23
4+
const val minSdkVersion = 21
55
}

buildSrc/src/main/java/Dep.kt

+6-6
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,19 @@ object Dep {
2525
object Versions {
2626
// Kotlin
2727

28-
const val kotlin = "1.3.20"
28+
const val kotlin = "1.3.61"
2929
const val junit = "4.12"
30-
const val retrofit = "2.5.0"
30+
const val retrofit = "2.7.1"
3131

3232
// Android
3333

34-
const val appCompat = "1.0.2"
35-
const val material = "1.0.0"
34+
const val appCompat = "1.2.0-alpha01"
35+
const val material = "1.2.0-alpha03"
3636
const val testRunner = "1.1.1"
3737
const val espresso = "3.1.1"
38-
const val constraintLayout = "2.0.0-alpha3"
38+
const val constraintLayout = "2.0.0-beta4"
3939
const val picasso = "2.71828"
40-
const val groupie = "2.3.0"
40+
const val groupie = "2.7.2"
4141
const val rebound = "0.3.8"
4242
const val rvAnimators = "3.0.0"
4343
}

buildSrc/src/main/java/versioning.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
object Versioning {
22
private val semantic = Semantic(
3-
major = 0,
3+
major = 1,
44
minor = 0,
5-
patch = 1
5+
patch = 0
66
)
77

88
val version = semantic.toVersion()

gradle/wrapper/gradle-wrapper.jar

1.8 KB
Binary file not shown.
+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.3-all.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists

showcase/build.gradle.kts

+6-4
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import org.jetbrains.kotlin.gradle.internal.AndroidExtensionsExtension
21
import java.util.*
32

43
plugins {
@@ -59,9 +58,12 @@ android {
5958
// IMPORTANT! Enables view caching in viewholders.
6059
// See: https://github.com/Kotlin/KEEP/blob/master/proposals/android-extensions-entity-caching.md
6160
androidExtensions {
62-
configure(delegateClosureOf<AndroidExtensionsExtension> {
63-
isExperimental = true
64-
})
61+
isExperimental = true
62+
}
63+
64+
compileOptions {
65+
sourceCompatibility = JavaVersion.VERSION_1_8
66+
targetCompatibility = JavaVersion.VERSION_1_8
6567
}
6668
}
6769

showcase/src/main/java/tomo/showcase/mainScreen/MainActivity.kt

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,20 @@ import androidx.appcompat.app.AppCompatActivity
88
import androidx.core.app.ActivityOptionsCompat
99
import androidx.recyclerview.widget.LinearLayoutManager
1010
import com.xwray.groupie.GroupAdapter
11-
import com.xwray.groupie.kotlinandroidextensions.ViewHolder
11+
import com.xwray.groupie.kotlinandroidextensions.GroupieViewHolder
1212
import jp.wasabeef.recyclerview.animators.LandingAnimator
1313
import kotlinx.android.synthetic.main.activity_main.*
1414
import tomo.Tomo
15-
import tomo.showcase.data.MovieId
1615
import tomo.showcase.R
1716
import tomo.showcase.app
1817
import tomo.showcase.common.handleCommonMenuClick
1918
import tomo.showcase.common.inflateCommonMenu
20-
import tomo.showcase.detailsScreen.DetailsActivity
2119
import tomo.showcase.common.post
20+
import tomo.showcase.data.MovieId
21+
import tomo.showcase.detailsScreen.DetailsActivity
2222

2323
class MainActivity : AppCompatActivity() {
24-
private val adapter = GroupAdapter<ViewHolder>()
24+
private val adapter = GroupAdapter<GroupieViewHolder>()
2525

2626
override fun onCreate(savedInstanceState: Bundle?) {
2727
super.onCreate(savedInstanceState)

showcase/src/main/java/tomo/showcase/mainScreen/groupie_items.kt

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import android.view.animation.AccelerateDecelerateInterpolator
77
import android.view.animation.OvershootInterpolator
88
import android.widget.ImageView
99
import com.squareup.picasso.Picasso
10+
import com.xwray.groupie.kotlinandroidextensions.GroupieViewHolder
1011
import com.xwray.groupie.kotlinandroidextensions.Item
11-
import com.xwray.groupie.kotlinandroidextensions.ViewHolder
1212
import kotlinx.android.synthetic.main.item_hi.*
1313
import kotlinx.android.synthetic.main.item_poster.*
1414
import tomo.showcase.R
@@ -19,7 +19,7 @@ import tomo.showcase.data.MovieId
1919
import kotlin.math.roundToInt
2020

2121
class HiItem : Item(0) {
22-
override fun bind(viewHolder: ViewHolder, position: Int) {
22+
override fun bind(viewHolder: GroupieViewHolder, position: Int) {
2323
with(viewHolder) {
2424
hiPopcornView.scaleViewUp()
2525
.setStartDelay(2_000L)
@@ -53,7 +53,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
5353
private const val MAX_GENRE_ICONS = 5
5454
}
5555

56-
override fun bind(viewHolder: ViewHolder, position: Int) = with(viewHolder) {
56+
override fun bind(viewHolder: GroupieViewHolder, position: Int) = with(viewHolder) {
5757
posterCard.setOnClickListener { onClick(movie.movieId, posterIv) }
5858

5959
posterTitleTv.text = movie.title.value
@@ -70,7 +70,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
7070
revealInfoWithAnimation()
7171
}
7272

73-
override fun unbind(holder: ViewHolder) {
73+
override fun unbind(holder: GroupieViewHolder) {
7474
super.unbind(holder)
7575
holder.posterBackground.clearAnimation()
7676
}
@@ -81,7 +81,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
8181
.fetch()
8282
}
8383

84-
private fun ViewHolder.revealInfoWithAnimation() {
84+
private fun GroupieViewHolder.revealInfoWithAnimation() {
8585
posterBackground.post {
8686
posterBackground.translationX = -(posterBackground.width).toFloat()
8787

@@ -93,7 +93,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
9393
}
9494
}
9595

96-
private fun ViewHolder.renderPoster() {
96+
private fun GroupieViewHolder.renderPoster() {
9797
val screenWidthPx = itemView.windowSize().x
9898
val posterWidthPx = screenWidthPx * POSTER_WIDTH_PERCENT
9999
val posterHeightPx = posterWidthPx / POSTER_ASPECT_RATIO
@@ -110,7 +110,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
110110
.into(posterIv)
111111
}
112112

113-
private fun ViewHolder.renderGenreIcons(inflater: LayoutInflater): LayoutInflater {
113+
private fun GroupieViewHolder.renderGenreIcons(inflater: LayoutInflater): LayoutInflater {
114114
posterGenreLl.removeAllViews()
115115
movie.genres.map(::genreToDrawableId).take(MAX_GENRE_ICONS).forEach { drawableId ->
116116
val view = inflater.inflate(R.layout.layout_poster_genre_icon, posterGenreLl, false)
@@ -123,7 +123,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
123123
return inflater
124124
}
125125

126-
private fun ViewHolder.renderScore(
126+
private fun GroupieViewHolder.renderScore(
127127
inflater: LayoutInflater,
128128
numberOfFullStars: Int,
129129
showAHalfStar: Boolean
@@ -147,7 +147,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
147147

148148
override fun getLayout(): Int = R.layout.item_poster
149149

150-
override fun isSameAs(other: com.xwray.groupie.Item<*>?): Boolean =
150+
override fun isSameAs(other: com.xwray.groupie.Item<*>): Boolean =
151151
(other as? PosterItem)?.movie?.movieId == movie.movieId
152152

153153
override fun equals(other: Any?): Boolean = isSameAs(other as com.xwray.groupie.Item<*>)
@@ -156,7 +156,7 @@ class PosterItem(private val movie: Movie, private val onClick: (MovieId, View)
156156
}
157157

158158
class SpaceItem : Item(1) {
159-
override fun bind(viewHolder: ViewHolder, position: Int) = Unit
159+
override fun bind(viewHolder: GroupieViewHolder, position: Int) = Unit
160160
override fun getLayout(): Int = R.layout.item_space
161161
}
162162

tomo/src/androidTest/java/tomo/view/ExampleInstrumentedTest.java

-26
This file was deleted.

tomo/src/test/java/tomo/view/ExampleUnitTest.java

-17
This file was deleted.

0 commit comments

Comments
 (0)