Skip to content

Commit b9bc1bf

Browse files
authored
Merge branch 'dev' into dependabot/npm_and_yarn/Control/dev-dependencies-dd3ddd0cf0
2 parents 283fd86 + 1c91d3c commit b9bc1bf

File tree

21 files changed

+749
-154
lines changed

21 files changed

+749
-154
lines changed

Framework/package-lock.json

Lines changed: 50 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Framework/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
]
3232
},
3333
"dependencies": {
34-
"express": "^4.21.2",
34+
"express": "^4.22.1",
3535
"helmet": "^8.1.0",
3636
"jsonwebtoken": "^9.0.0",
3737
"kafkajs": "^2.2.0",
@@ -51,7 +51,7 @@
5151
"mocha": "^11.7.0",
5252
"nock": "15.0.0",
5353
"nyc": "^17.1.0",
54-
"puppeteer": "^24.33.0",
54+
"puppeteer": "^24.34.0",
5555
"sinon": "21.0.0",
5656
"supertest": "^7.1.0",
5757
"long": "^5.3.1"

QualityControl/package-lock.json

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

QualityControl/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"eslint-plugin-jsdoc": "^61.5.0",
5555
"globals": "^16.5.0",
5656
"nock": "^15.0.0",
57-
"puppeteer": "^24.33.0",
57+
"puppeteer": "^24.34.0",
5858
"sequelize-cli": "^6.6.2",
5959
"sinon": "^21.0.0",
6060
"supertest": "^7.1.0"

QualityControl/public/Model.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ export default class Model extends Observable {
169169
this.object.objects = {}; // Remove any in-memory loaded objects
170170
this._clearAllIntervals();
171171
await this.filterModel.filterService.initFilterService();
172-
this.filterModel.setFilterFromURL();
172+
await this.filterModel.setFilterFromURL();
173173
this.filterModel.setFilterToURL();
174174

175175
this.services.layout.getLayoutsByUserId(this.session.personid, RequestFields.LAYOUT_CARD);

QualityControl/public/app.css

Lines changed: 47 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
/* overwrite jsroot styles */
7979
.jsroot-container {}
8080
.jsroot-container pre { background-color: initial; }
81-
.jsrootdiv:hover + .resize-element, .resize-element:hover{ display: flex !important; }
81+
.jsrootdiv:hover + .resize-element, .resize-element:hover{ display: flex !important; visibility: visible !important; }
8282

8383
.item-action-row { position: absolute; right: 0%; z-index: 100 }
8484

@@ -152,9 +152,14 @@
152152
}
153153
}
154154

155-
.cursor-pointer {
156-
cursor: pointer;
157-
}
155+
.cursor-pointer { cursor: pointer; }
156+
.cursor-grab { cursor: grab; }
157+
.cursor-inherit { cursor: inherit; }
158+
159+
.b1 { border-style: solid; border-width: 1px; }
160+
161+
.b-danger { border-color: var(--color-danger); }
162+
.b-success { border-color: var(--color-success); }
158163

159164
.header-layout {
160165
&.edit {
@@ -187,3 +192,41 @@
187192
.whitespace-nowrap {
188193
white-space: nowrap;
189194
}
195+
196+
.drop-zone {
197+
position: absolute;
198+
height: 100%;
199+
width: 50%;
200+
pointer-events: none;
201+
202+
&.before {
203+
left: 0;
204+
205+
&.active {
206+
border-left: 2px solid var(--color-primary);
207+
}
208+
}
209+
210+
&.after {
211+
right: 0;
212+
213+
&.active {
214+
border-right: 2px solid var(--color-primary);
215+
}
216+
}
217+
}
218+
219+
.pointer-events-auto {
220+
pointer-events: auto;
221+
}
222+
.pointer-events-none {
223+
pointer-events: none;
224+
}
225+
226+
/* This hacky workaround is required due to `justify-content: center;` being unusable thanks to a horizontal scrolling bug */
227+
#header-detector-qualities {
228+
&::before, &::after {
229+
content: '';
230+
flex: 1;
231+
}
232+
}
Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,40 @@
1+
/**
2+
* @license
3+
* Copyright 2019-2020 CERN and copyright holders of ALICE O2.
4+
* See http://alice-o2.web.cern.ch/copyright for details of the copyright holders.
5+
* All rights not expressly granted are reserved.
6+
*
7+
* This software is distributed under the terms of the GNU General Public
8+
* License v3 (GPL Version 3), copied verbatim in the file "COPYING".
9+
*
10+
* In applying this license CERN does not waive the privileges and immunities
11+
* granted to it by virtue of its status as an Intergovernmental Organization
12+
* or submit itself to any jurisdiction.
13+
*/
14+
15+
import { h, iconCheck, iconX } from '/js/src/index.js';
16+
17+
/**
18+
* A green success badge with the tick icon
19+
* @param {string} text - Text to display in the badge
20+
* @returns {vnode} The badge virtual node
21+
*/
22+
export const statusBadgeSuccess = (text) =>
23+
h('.badge.success.b-success.b1', h('.flex-row.g1', [text, iconCheck()]));
24+
25+
/**
26+
* A red failure badge with the X icon
27+
* @param {string} text - Text to display in the badge
28+
* @returns {vnode} The badge virtual node
29+
*/
30+
export const statusBadgeFail = (text) =>
31+
h('.badge.danger.b-danger.b1', h('.flex-row.g1', [text, iconX()]));
32+
33+
/**
34+
* A status badge with dynamic color and icon depending on success or failure.
35+
* @param {string} text - Text to display inside the badge
36+
* @param {boolean} success - Whether the badge represents success (`true`) or failure (`false`)
37+
* @returns {vnode} The badge virtual node
38+
*/
39+
export const statusBadge = (text, success) =>
40+
success ? statusBadgeSuccess(text) : statusBadgeFail(text);

0 commit comments

Comments
 (0)