Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests are invalid #108

Open
noa-codes opened this issue Jun 15, 2023 · 0 comments
Open

Unit tests are invalid #108

noa-codes opened this issue Jun 15, 2023 · 0 comments

Comments

@noa-codes
Copy link

noa-codes commented Jun 15, 2023

Hi - Thanks for this terrific paper and thank you for sharing the code!

Just wanted to point out that the tests in tests/test_asl.py are not valid, and they all fail, e.g.

======================================================================
FAIL: test_forward_clipped_logits (tests.test_asl.TestAsymmetricLoss)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/nbenditshtull/development/ASL/tests/test_asl.py", line 62, in test_forward_clipped_logits
    self.assertEqual(self.loss(x, y), expected_loss)
AssertionError: tensor(3.8641) != tensor(0.3188)

======================================================================
FAIL: test_forward_disable_torch_grad_focal_loss (tests.test_asl.TestAsymmetricLoss)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/nbenditshtull/development/ASL/tests/test_asl.py", line 90, in test_forward_disable_torch_grad_focal_loss
    self.assertEqual(self.loss(x, y), expected_loss)
AssertionError: tensor(3.8641) != tensor(0.3188)

======================================================================
FAIL: test_forward_eps (tests.test_asl.TestAsymmetricLoss)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/nbenditshtull/development/ASL/tests/test_asl.py", line 83, in test_forward_eps
    self.assertEqual(self.loss(x, y), expected_loss)
AssertionError: tensor(1.1670) != tensor(0.3162)
@noa-codes noa-codes changed the title Tests are invalid, they all fail Tests are invalid, all but one fail Jun 15, 2023
@noa-codes noa-codes changed the title Tests are invalid, all but one fail Unit tests are invalid Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant