Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spatial data in coldata_to_df() #77

Open
jashapiro opened this issue Dec 3, 2021 · 3 comments
Open

Support spatial data in coldata_to_df() #77

jashapiro opened this issue Dec 3, 2021 · 3 comments

Comments

@jashapiro
Copy link
Member

In , @allyhawkins created a function spatial_coldata_to_df() that adds some of the data from the spatialData slot of a SpatialExperiment to the main colData contents after merging.

For scpcaTools, I think it would make sense to wrap that functionality into coldata_to_df(), where the function would check whether we were working with a SpatialExperiment, and if so, merge all contents of the spatialData slot with the colData contents.

There is a small wrinkle in that we expect spatialData to go away in a future version of the SpatialExperiment package drighelli/SpatialExperiment#84. We should plan to deal with that case as we write this for futureproofing.

@jaclyn-taroni
Copy link
Member

I am going to slot this for next sprint for discussion. From what's written, it does seem like this could be an enhancement that we don't need to do.

@allyhawkins
Copy link
Member

I would say that this is no longer needed, since we aren't doing any import of the spatial output into spatial experiments in R at all currently. It might be helpful to have in the package if we ever were planning to do downstream analysis on spatial libraries, but this isn't necessary for processing the spatial data to be available on the portal.

@jaclyn-taroni
Copy link
Member

I'm going to remove this from the sprint and the Epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants