Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow include_altexps to take a vector in merge_sce_list #262

Open
jashapiro opened this issue Jan 25, 2024 · 0 comments
Open

Allow include_altexps to take a vector in merge_sce_list #262

jashapiro opened this issue Jan 25, 2024 · 0 comments

Comments

@jashapiro
Copy link
Member

          For the future, part of me wonders if we should allow `include_altexps` to be a vector of `altExps` to include. This would be a change in `scpcaTools`, and for backward compatibility we should allow a `TRUE/FALSE` to mean keep all or keep none, with a vector meaning (implicitly) keep some. 

Originally posted by @jashapiro in AlexsLemonade/scpca-nf#666 (comment)

The idea here is that we could allow

merge_sce_list(sce_list, include_altexp = c("adt")) 

to keep only the adt altExp, even if there were also a cellhash altExp that we wanted to exclude.

merge_sce_list(sce_list, include_altexp = FALSE) 

would still work as before and not include any altExps, and TRUE would include all altExps.

This does not need to be implemented until we think we will have data that actually does contain more than one altExp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant