Fixes (sous-chefs#609)

Author: JohnRoesler

.circleci/config.yml

@@ -1,13 +1,32 @@
-version: 2.1
+---
+jobs:
+  final:
+    docker:
+      - image: bash:latest
+    steps:
+      - run:
+          name: Finish cooking
+          command: echo "Finished cooking"
 
+lint_and_unit: &lint_and_unit
+  - delivery
+  - danger
+  - lint-yaml
+  - lint-markdown
+version: 2.1
 orbs:
-  kitchen: sous-chefs/[email protected]
-
+  kitchen: sous-chefs/kitchen@2
 workflows:
   kitchen:
     jobs:
+      - kitchen/yamllint:
+          name: lint-yaml
+      - kitchen/mdlint:
+          name: lint-markdown
       - kitchen/danger:
           name: danger
           context: Danger
-      - kitchen/lint:
-          name: lint
+      - kitchen/delivery:
+          name: delivery
+      - final:
+          requires: *lint_and_unit

.github/lock.yml

@@ -1,3 +1,4 @@
+---
 # Configuration for lock-threads - https://github.com/dessant/lock-threads
 
 # Number of days of inactivity before a closed issue or pull request is locked

.kitchen.dokken.yml

@@ -0,0 +1 @@
+rules "~MD013", "~MD024"

.mdlrc

@@ -1,3 +1,4 @@
+---
 AllCops:
   Exclude:
     - 'Dangerfile'

.rubocop.yml

@@ -0,0 +1,9 @@
+extends: default
+ignore: .kitchen/
+rules:
+  line-length:
+    max: 120
+    level: warning
+  document-start:
+    ignore: |
+      kitchen.yml

.yamllint

@@ -13,6 +13,9 @@ This file is used to list changes made in each version of the mysql cookbook.
 - Add a helper for Ubuntu 18.04
 - Remove support for Debian 7
 - Remove ChefSpec matchers
+- Set apparmor tmp_dir permissions on directory itself
+- Run latest cookstyle
+- Circleci, Yaml and markdown lint updates
 
 ## 8.5.1 (2017-08-23)
 
@@ -39,20 +42,23 @@ This file is used to list changes made in each version of the mysql cookbook.
 - Remove mention of the EOL opensuse 13.x in the readme
 
 ## 8.3.0 (2017-03-20)
+
 - Refactor mysql_service_manager_upstart.rb to eliminate use of cloned resource
 
 ## 8.2.0 (2016-12-03)
 
 - Include client development packages on RHEL/SUSE platforms
 
 ## 8.1.1 (2016-10-31)
+
 - Fixing CVE-2016-6662 - Reverting execure bit on mysql config
 
 ## 8.1.0 (2016-10-29)
 
 - Drop hardcoded, specific package version logic that broke many users
 
 ## 8.0.4 (2016-09-26)
+
 - Bump debian version
 - Updated packages for 12.04 and 14.04 too
 - Add chef_version metadata
@@ -61,18 +67,21 @@ This file is used to list changes made in each version of the mysql cookbook.
 - Make sure yum repos are setup in local Test Kitchen
 
 ## 8.0.3 (2016-09-14)
+
 - [GH-390] Fix #390 incorrect escaping of initial_root_password
 - Updated package versions for Ubuntu 16.04
 - Testing updates
 
-# v8.0.2 (2016-08-25)
+## v8.0.2 (2016-08-25)
+
 - Various bug fixed and updates to package version strings
 
-# v8.0.1 (2016-07-20)
+## v8.0.1 (2016-07-20)
+
 - Fixed a regression in the mysql_client resource where the action was changed from create to install in the 8.0 release
 - Added oracle, opensuse, and opensuseleap as supported platforms in the metadata
 
-# v8.0.0 (2016-07-11)
+## v8.0.0 (2016-07-11)
 
 - Converting from LWRP to custom resources
 - Removing yum-mysql and other dependencies.
@@ -488,7 +497,7 @@ Locking yum dependency to '< 3'
 
 ## v4.0.6
 
-# Bug
+### Bug
 
 - [COOK-3943] Notifying service restart on grants update
 
@@ -610,7 +619,7 @@ Locking yum dependency to '< 3'
 
 ## v2.0.0
 
-**Important note for this release**
+### Important note for this release
 
 Under Chef Solo, you must set the node attributes for the root, debian and repl passwords or the run will completely fail. See COOK-1737 for background on this.
 
@@ -627,7 +636,7 @@ Under Chef Solo, you must set the node attributes for the root, debian and repl
 
 ## v1.3.0
 
-**Important note for this release**
+### Important note for this release
 
 This version no longer installs Ruby bindings in the client recipe by default. Use the ruby recipe if you'd like the RubyGem. If you'd like packages from your distribution, use them in your application's specific cookbook/recipe, or modify the client packages attribute. This resolves the following tickets:
 

CHANGELOG.md

@@ -1,2 +1,2 @@
 Please refer to
-https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
+[https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD](https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD)

TESTING.md

@@ -0,0 +1,72 @@
+---
+driver:
+  name: dokken
+  privileged: true  # because Docker and SystemD/Upstart
+  chef_version: <%= ENV['CHEF_VERSION'] || 'current' %>
+  env: [CHEF_LICENSE=accept]
+
+transport:
+  name: dokken
+
+provisioner:
+  name: dokken
+  deprecations_as_errors: true
+
+platforms:
+  - name: amazonlinux
+    driver:
+      image: dokken/amazonlinux
+      pid_one_command: /sbin/init
+
+  - name: amazonlinux-2
+    driver:
+      image: dokken/amazonlinux-2
+      pid_one_command: /usr/lib/systemd/systemd
+
+  - name: debian-8
+    driver:
+      image: dokken/debian-8
+      pid_one_command: /bin/systemd
+      intermediate_instructions:
+        - RUN /usr/bin/apt-get update
+
+  - name: debian-9
+    driver:
+      image: dokken/debian-9
+      pid_one_command: /bin/systemd
+      intermediate_instructions:
+        - RUN /usr/bin/apt-get update
+
+  - name: centos-6
+    driver:
+      image: dokken/centos-6
+      pid_one_command: /sbin/init
+
+  - name: centos-7
+    driver:
+      image: dokken/centos-7
+      pid_one_command: /usr/lib/systemd/systemd
+
+  - name: fedora-latest
+    driver:
+      image: dokken/fedora-latest
+      pid_one_command: /usr/lib/systemd/systemd
+
+  - name: ubuntu-16.04
+    driver:
+      image: dokken/ubuntu-16.04
+      pid_one_command: /bin/systemd
+      intermediate_instructions:
+        - RUN /usr/bin/apt-get update
+
+  - name: ubuntu-18.04
+    driver:
+      image: dokken/ubuntu-18.04
+      pid_one_command: /bin/systemd
+      intermediate_instructions:
+        - RUN /usr/bin/apt-get update
+
+  - name: opensuse-leap
+    driver:
+      image: dokken/opensuse-leap
+      pid_one_command: /bin/systemd