-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Comments to a Static Site with Netlify Functions and the GitHub API #117
Comments
Thanks for this great tutorial! I'm just beginning to work through it. One typo I just came across is that in Testing Netlify Functions Locally the flag should be |
@AustenLamacraft Thanks for letting me know! Fixed. |
Is there a reason not to use GitHub issues (first entry) also as the source of the article itself? I see some good benefits of doing that:
Some potential issues that I see:
I want to give it a try but wanted to mention here first to get early insights about this idea. |
@muratcorlu It's certainly an interesting idea. One reason I might not do this is because it ties you down to that one repo, whereas imo your articles should be independent media that you can transfer between different CMSes/source control platforms as needed. Another reason is that authoring posts in GitHub issues limits your ability to add custom styling, JavaScript, semantics, and other design elements. For example, you can't use shortcodes (e.g., 11ty) or MDX (Next/Gatsby). If it works for you, though, go for it! |
Enjoyed the information in the article. Also the article on Twitter was so true. It will take over and you have to take a break from all social media. Thank you |
One more typo: const { data: rateLimitInfo } = await Octokit.rateLimit.get(); Should read: const { data: rateLimitInfo } = await octokitClient.rateLimit.get(); |
Oops 😅 Thanks! @JeffML |
No description provided.
The text was updated successfully, but these errors were encountered: