From 6235eafe2bd30f3ae8f5a54edb1d7b75a884a35a Mon Sep 17 00:00:00 2001 From: Albert Hernandez Pellicer Date: Sat, 10 Feb 2024 12:24:09 +0100 Subject: [PATCH 1/4] ci(node): improve nodejs cache --- .github/workflows/node.yml | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml index edb3818..b16f503 100644 --- a/.github/workflows/node.yml +++ b/.github/workflows/node.yml @@ -10,16 +10,17 @@ jobs: steps: - name: Checkout 🛬 uses: actions/checkout@v4 - - name: Setup Node ⚙️ - uses: actions/setup-node@v4 - with: - node-version-file: '.nvmrc' - name: Cache Dependencies ⌛️ uses: 'actions/cache@v4' id: cache-node-modules with: path: 'node_modules' - key: deps-node-modules-${{ hashFiles('**/package-lock.json') }} + key: ${{ runner.os }}-node_modules-${{ hashFiles('package*.json') }}-${{ hashFiles('.github/workflows/node.yml') }} + - name: Setup Node ⚙️ + uses: actions/setup-node@v4 + with: + node-version-file: '.nvmrc' + cache: npm - name: Install dependencies 📥 if: steps.cache-node-modules.outputs.cache-hit != 'true' run: npm ci From a5a51bd52a4d74fbd1fe37b992b9080bf03ec468 Mon Sep 17 00:00:00 2001 From: Albert Hernandez Pellicer Date: Sat, 10 Feb 2024 12:26:29 +0100 Subject: [PATCH 2/4] docs: modify readme to check cache --- README.md | 1 - 1 file changed, 1 deletion(-) diff --git a/README.md b/README.md index 9c75eb4..8272c4e 100644 --- a/README.md +++ b/README.md @@ -20,7 +20,6 @@ ## 👀 Motivation Starting a new service in NodeJS can be a bit frustrating, there are a lot of things to consider if we want to have a really good starting point where later we can iterate. - The main objective of this template is to provide a good base configuration for our NodeJS services that we can start using and move to production as soon as possible. ## 🌟 What is including this template? From 8a8cfaf6dce7960f2c8ed4074ce74b886adb8d72 Mon Sep 17 00:00:00 2001 From: Albert Hernandez Pellicer Date: Sat, 10 Feb 2024 12:27:47 +0100 Subject: [PATCH 3/4] Revert "docs: modify readme to check cache" This reverts commit a5a51bd52a4d74fbd1fe37b992b9080bf03ec468. --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 8272c4e..9c75eb4 100644 --- a/README.md +++ b/README.md @@ -20,6 +20,7 @@ ## 👀 Motivation Starting a new service in NodeJS can be a bit frustrating, there are a lot of things to consider if we want to have a really good starting point where later we can iterate. + The main objective of this template is to provide a good base configuration for our NodeJS services that we can start using and move to production as soon as possible. ## 🌟 What is including this template? From 4cb279a51ef50fb49f2dfb7b65245134ca5281d2 Mon Sep 17 00:00:00 2001 From: Albert Hernandez Pellicer Date: Sat, 10 Feb 2024 12:29:48 +0100 Subject: [PATCH 4/4] ci(node): remove quotes --- .github/workflows/node.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/node.yml b/.github/workflows/node.yml index b16f503..cb9e44d 100644 --- a/.github/workflows/node.yml +++ b/.github/workflows/node.yml @@ -11,7 +11,7 @@ jobs: - name: Checkout 🛬 uses: actions/checkout@v4 - name: Cache Dependencies ⌛️ - uses: 'actions/cache@v4' + uses: actions/cache@v4 id: cache-node-modules with: path: 'node_modules'