Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for building with cmake #22

Open
aivazis opened this issue Jan 28, 2020 · 2 comments
Open

add support for building with cmake #22

aivazis opened this issue Jan 28, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@aivazis
Copy link
Member

aivazis commented Jan 28, 2020

now that pyre builds with cmake, we should add cmake support in altar and retire the default build system

@aivazis aivazis added enhancement New feature or request good first issue Good for newcomers labels Jan 28, 2020
@aivazis aivazis self-assigned this Jan 29, 2020
@lijun99
Copy link
Contributor

lijun99 commented Jan 30, 2020

I tried cmake on Linux and it worked perfectly!

  1. I will try Mac/Anaconda when I get access to a mac;
  2. I will follow your example to write a cmake file for the seismic model as well as for cuda extensions;
  3. I can also take care of the installation how-to.

@lijun99
Copy link
Contributor

lijun99 commented Feb 1, 2020

I have added cmake support to cuda extensions in pyre and altar as well. All things go well. The only hassle is that when using enable_language(CUDA) instead of FindCUDA, it does not seem to work inside a function and has to be put under PARENT_SCOPE. I will do more tests and write a guide next week. Mac/Anaconda also works well. Shall we write a setup.py to make the installation step even simpler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants