From 3334d0de5b2dc66eaa77aa448815cb9c7761a23c Mon Sep 17 00:00:00 2001 From: pochern Date: Wed, 31 May 2023 22:58:42 -0400 Subject: [PATCH 1/2] Specify deep option on array watchers --- packages/floating-vue/src/components/Popper.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/packages/floating-vue/src/components/Popper.ts b/packages/floating-vue/src/components/Popper.ts index 76e38860..850223fc 100644 --- a/packages/floating-vue/src/components/Popper.ts +++ b/packages/floating-vue/src/components/Popper.ts @@ -374,7 +374,10 @@ export default () => defineComponent({ 'triggers', 'positioningDisabled', ].reduce((acc, prop) => { - acc[prop] = '$_refreshListeners' + acc[prop] = { + handler: '$_refreshListeners', + deep: true, + }; return acc }, {}), @@ -391,7 +394,10 @@ export default () => defineComponent({ 'shiftCrossAxis', 'flip', ].reduce((acc, prop) => { - acc[prop] = '$_computePosition' + acc[prop] = { + handler: '$_computePosition', + deep: true, + }; return acc }, {}), }, From fa362b82bcb935be96beffec6a651a1ef738ae01 Mon Sep 17 00:00:00 2001 From: pochern Date: Thu, 1 Jun 2023 00:35:38 -0400 Subject: [PATCH 2/2] Remove semicolon after curly brace - lint fix --- packages/floating-vue/src/components/Popper.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/floating-vue/src/components/Popper.ts b/packages/floating-vue/src/components/Popper.ts index 850223fc..cfce246b 100644 --- a/packages/floating-vue/src/components/Popper.ts +++ b/packages/floating-vue/src/components/Popper.ts @@ -377,7 +377,7 @@ export default () => defineComponent({ acc[prop] = { handler: '$_refreshListeners', deep: true, - }; + } return acc }, {}), @@ -397,7 +397,7 @@ export default () => defineComponent({ acc[prop] = { handler: '$_computePosition', deep: true, - }; + } return acc }, {}), },