Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Twig "use_yield" Option Compatibility Issue in NotFloran\MjmlBundle\Twig\Node with Shopware 6.6.9.0 #96

Closed
wbm-ahasanain opened this issue Dec 9, 2024 · 1 comment · Fixed by #97

Comments

@wbm-ahasanain
Copy link

We encountered an issue when upgrading to Shopware 6.6.9.0. The problem arises with the Twig "use_yield" option in the NotFloran\MjmlBundle\Twig\Node class. When compiling email templates like @ThemeName/email/base.html.twig, the following exception is thrown:

An exception has been thrown during the compilation of a template ("You cannot enable the "use_yield" option of Twig as node "NotFloran\MjmlBundle\Twig\Node" is not marked as ready for it; please make it ready and then flag it with the #[YieldReady] attribute.") in "@Test/email/base.html.twig".

Workaround:
We were able to resolve this issue by manually adding the #[YieldReady] attribute to the NotFloran\MjmlBundle\Twig\Node class.

Could you please review if the NotFloran\MjmlBundle\Twig\Node class is compatible with the "use_yield" option and, if appropriate, mark it with the #[YieldReady] attribute? This issue prevents email templates from being compiled correctly in Shopware 6.6.9.0.

Thank you for your assistance.

@notFloran
Copy link
Member

Good point, I forgot #[YieldReady] in the previous PR.

I open a PR #97 to fix that. Once merged I will make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants