Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git clone install is broken #9

Open
nihil-admirari opened this issue Nov 27, 2023 · 4 comments
Open

Git clone install is broken #9

nihil-admirari opened this issue Nov 27, 2023 · 4 comments

Comments

@nihil-admirari
Copy link

README command

git clone 'https://github.com/Ajatt-Tools/FlexibleGrading.git' ~/.local/share/Anki2/addons21/FlexibleGrading

lacks --recurse-submodules. Adding it asks for SSH password, since ajt_common submodule uses SSH [email protected]:Ajatt-Tools/ajt_common.git instead of HTTPS.

Fixing this issue is troublesome:

  1. Using HTTPS for submodule would require manual adjustment of submodule remotes in order to do pushes.
  2. Apparently .gitmodules doesn't allow one to specify a separate push URL, which would've allowed HTTPS for pulls and SSH only for pushes, i.e. automating the first option is not possible.
  3. Using a relative path ../ajt_common.git will not work for someone who forked only the addon without forking the submodule.
@tatsumoto-ren
Copy link
Member

Added --recurse-submodules to the readme. I think it's better if it asks for the ssh password than if it fails.

You can also use ssh for everything, including the main git clone.

@nihil-admirari
Copy link
Author

You can also use ssh for everything, including the main git clone.

I'd rather not. It requires either inputting the password for every operation or running an ssh-agent in a terminal window that never closes. And if someone manages to get access to that terminal, the ssh-agent will grant him access to my GitHub with no questions asked.

@tatsumoto-ren
Copy link
Member

If you run ssh-agent in background before launching a desktop session, you won't need to have a terminal window open all the time. Or you can use setsid -f.

@nihil-admirari
Copy link
Author

I'm using ssh-agent bound to a specific tty only when pushing for security reasons, not because it can't be done differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants