Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decline reason not visible #2509

Open
maciejmaciejko-gid opened this issue Jun 19, 2024 · 6 comments
Open

Decline reason not visible #2509

maciejmaciejko-gid opened this issue Jun 19, 2024 · 6 comments
Assignees
Labels
Backend Backend tasks enhancement New feature or request Frontend Relates to coral (react app)

Comments

@maciejmaciejko-gid
Copy link

maciejmaciejko-gid commented Jun 19, 2024

What happened?

The decline reason is required to decline request e.g. topic's creation. I don't see any field which can give that information back to request creator.

What did you expect to happen?

The decline reason should be visible to request creator.

What else do we need to know?

Klaw 2.9.0 old and new interface
Zrzut ekranu 2024-06-19 113559
Zrzut ekranu 2024-06-19 113621
Zrzut ekranu 2024-06-19 113657

@aindriu-aiven
Copy link
Contributor

At the moment we only email out the decline reason but this has been a bug bear of mine for a long time 😓 would love to get this added into the UI.

@aindriu-aiven aindriu-aiven added enhancement New feature or request Backend Backend tasks Frontend Relates to coral (react app) labels Jun 19, 2024
@dotarjun
Copy link
Contributor

Something like this?
image
I can open a PR and do this easily

@aindriu-aiven
Copy link
Contributor

Hey @dotarjun that would be a fantastic addition and one we have talked about making time to do at some point.

The decline reason is missing from the DB at the moment so we would also need to add a new column to the following tables as well.

  • kwaclrequests
  • kwschemarequests
  • kwtopicrequests
  • kwkafkaconnectorrequests

Would you be comfortable adding that information as well?

@aindriu-aiven
Copy link
Contributor

I'll assign this git issue to you @dotarjun if you need any help I'd be happy to help out!

@dotarjun
Copy link
Contributor

I was busy with work so got around to doing this now that I have some free time.

I am trying to create a new vite mode for remote api dev but I am not sure how to get the KLAW API ORIGIN.

Could you point me to the right docs. Thanks

@programmiri
Copy link
Contributor

@dotarjun - This would be a server where you have Klaw running, e.g. we've a staging environment running. I think you could also use a locally running Klaw.

https://<your-server-address>:9097

Alternatively you could run the proxy -> https://github.com/Aiven-Open/klaw/blob/main/coral/docs/development-with-local-klaw.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Backend tasks enhancement New feature or request Frontend Relates to coral (react app)
Projects
None yet
Development

No branches or pull requests

4 participants