feat(zoe): cache bundles in bundleAndInstall of setUpZoeForTest #10554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
bb713ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3a9f7d72.agoric-sdk.pages.dev |
| Branch Preview URL: | https://dc-ztest-cache.agoric-sdk.pages.dev |
mergify bot
added a commit
that referenced
this pull request
Nov 27, 2024
refs: #10388 closes: #10577 doesn't close until - exercise all the code in the contract (analytic; best effort) ## Description / Testing Considerations - [x] test all the sequences in the product spec - [x] enumerate all the sequences in the product spec - [x] fix advancer/settler amount agreement bug postponed: - - #10510 - [todo] C12 - Contract MUST only pay back the Pool only if they started the advance before USDC is minted - #10554 some `test.todo()`s are out of scope of contract flow tests. Some are more feasible as exo tests: - [todo] C18 - forward - MUST log and alert these incidents - [skip] LP borrow - TODO: move to exo test - [skip] LP repay - TODO: move to exo test an some are after M1: - [todo] PERF: Target: settlement completes in a few minutes (after USDC is minted) - [todo] fee levels MUST be visible to external parties - i.e., written to public storage - [todo] C21 - Contract MUST log / timestamp each step in the transaction flow ### Security / Scaling / Upgrade Considerations n/a ### Documentation Considerations Internal design docs are assumed background knowledge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT; goal:
closes: #10427
refs: #10550
Description / Testing Considerations
bundleAndInstallcache.bundleAndInstall.E(zoe).install(bundle)to usesetUpZoeForTestand its cachingbundleAndInstall.Security / Documentation Considerations
It's not clear that the cache works correctly with multiple concurrent tests.
There's a
bundleDiroption, but using that would largely defeat the purpose.Scaling Considerations
should make at least fast-usdc contract tests (#10550) run faster
Upgrade Considerations
n/a. test only