Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xsnap assumes yarn package manager #9261

Closed
turadg opened this issue Apr 19, 2024 · 1 comment
Closed

xsnap assumes yarn package manager #9261

turadg opened this issue Apr 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@turadg
Copy link
Member

turadg commented Apr 19, 2024

What is the Problem Being Solved?

The postinstall of @agoric/xsnap runs yarn build:from-env. If yarn isn't installed, this will fail. That means the package can't be installed by other package managers.

This relates to,

Description of the Design

Remove yarn from the package scripts. Should be done for all packages in the SDK.

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@turadg turadg added the enhancement New feature or request label Apr 19, 2024
turadg added a commit to Agoric/ui-kit that referenced this issue Apr 19, 2024
samsiegart added a commit to Agoric/ui-kit that referenced this issue Apr 24, 2024
* feat: query smart wallet auto-provision fee

* fix: remove extra purse updates and swingset query

* feat: onboard IST with elements button

* build: patch xsnap to separate from yarn project

works around Agoric/agoric-sdk#9261

* test(rpc): use legacy endo to fix test

* build: add prepack script

* build: fix some types

* chore: add comment for IST icon

---------

Co-authored-by: Turadg Aleahmad <[email protected]>
@turadg
Copy link
Member Author

turadg commented Jul 10, 2024

Fixed in #9262

@turadg turadg closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant