Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write contract config to vstorage #10509

Closed
LuqiPan opened this issue Nov 18, 2024 · 2 comments · Fixed by #10587
Closed

Write contract config to vstorage #10509

LuqiPan opened this issue Nov 18, 2024 · 2 comments · Fixed by #10587
Assignees

Comments

@LuqiPan
Copy link
Contributor

LuqiPan commented Nov 18, 2024

What is the Problem Being Solved?

Description of the Design

Security Considerations

Scaling Considerations

Test Plan

Upgrade Considerations

@samsiegart
Copy link
Contributor

In progress as in I'm working on figuring out the acceptance criteria with the team

@samsiegart
Copy link
Contributor

We've decided that we just need to publish the feeConfig to vstorage under published.fastUsdc.feeConfig

? What config should the contract publish?
  :- terms
    - Denoms already published elsewhere
  :- oracles
    - UI doesn't need to know these
  :+ FeedConfig
    + OCW requires this
    . Already published under `published.fastUsdc.feedConfig`
  :+ Fee config
    + UI requires this
    ?! where to publish Fee config
      :+ `published.fastUsdc.feeConfig`
        + clear lookup
        - if we add more contract config we'll have more keys
        + determined/changed at a different time than other config
      : `published.fastUsdc`
        + natural home for info about the contract
        + can hold a JSON that has feeConfig and whatever else
          - if we serialize with plain JSON then it can't ever have remotables or bigints
          - if we serialize with CapData then reading the feeConfig is harder
            + we're providing a library anyway to read the fees
  :+ poolMetrics
    . Liquidity pool already writes this
  :~  SettlerAccount address
    + Needed by UI to determine noble fwd address
    ! Is SettlerAccount known in advance? Might not qualify as "config". Can probably publish separately.
  :~  PoolAccount address
    ? Why would we need to know this?
    ! Is PoolAccount known in advance? Might not qualify as "config". Can probably publish separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants