Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove script that removes installed.php #600

Closed
sneakyvv opened this issue Jan 7, 2025 · 4 comments
Closed

Remove script that removes installed.php #600

sneakyvv opened this issue Jan 7, 2025 · 4 comments

Comments

@sneakyvv
Copy link
Contributor

sneakyvv commented Jan 7, 2025

Describe the bug
Since 3.17.1 this was added 3.17.0...3.17.1#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R54
This causes this error

require([...]/vendor/store.shopware.com/adyenpaymentshopware6/vendor/composer/installed.php): Failed to open stream: No such file or directory

Versions
Shopware version: 6.5.11
Plugin version: 3.17.1

To Reproduce
Run phpunit
It will run [...]/adyenpaymentshopware6/vendor/composer/InstalledVersions.php:341
self::$installed = require __DIR__ . '/installed.php';

Expected behavior
Don't crash

Screenshots
N/A

Desktop :

  • OS: WSL2/Ubuntu

Additional context
Why was this script added? No context found in the commit except a reference to CS-6204
It breaks our CI/CD pipeline

Stacktrace:

#0 vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php(132): PHPUnit\Util\ErrorHandler->__invoke(2, 'require(/home/s...', '/home/sneakyvv/...', 341, Array)
#1 vendor/store.shopware.com/adyenpaymentshopware6/vendor/composer/InstalledVersions.php(341): Symfony\Bridge\PhpUnit\DeprecationErrorHandler->handleError(2, 'require(/home/s...', '/home/sneakyvv/...', 341)
#2 vendor/store.shopware.com/adyenpaymentshopware6/vendor/composer/InstalledVersions.php(341): require('/home/sneakyvv/...')
#3 vendor/store.shopware.com/adyenpaymentshopware6/vendor/composer/InstalledVersions.php(97): Composer\InstalledVersions::getInstalled()
#4 vendor/shopware/core/Profiling/Profiling.php(71): Composer\InstalledVersions::isInstalled('symfony/web-pro...')
#5 vendor/shopware/core/Profiling/Profiling.php(40): Shopware\Core\Profiling\Profiling->buildConfig(Object(Symfony\Component\DependencyInjection\ContainerBuilder), 'test')
#6 vendor/symfony/http-kernel/Kernel.php(609): Shopware\Core\Profiling\Profiling->build(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#7 vendor/symfony/http-kernel/Kernel.php(584): Symfony\Component\HttpKernel\Kernel->prepareContainer(Object(Symfony\Component\DependencyInjection\ContainerBuilder))
#8 vendor/symfony/http-kernel/Kernel.php(486): Symfony\Component\HttpKernel\Kernel->buildContainer()
#9 vendor/shopware/core/Kernel.php(166): Symfony\Component\HttpKernel\Kernel->initializeContainer()
#10 vendor/shopware/core/Framework/Test/TestCaseBase/KernelLifecycleManager.php(58): Shopware\Core\Kernel->boot()
#11 vendor/shopware/core/TestBootstrapper.php(311): Shopware\Core\Framework\Test\TestCaseBase\KernelLifecycleManager::getKernel()
#12 vendor/shopware/core/TestBootstrapper.php(345): Shopware\Core\TestBootstrapper->getKernel()
#13 vendor/shopware/core/TestBootstrapper.php(80): Shopware\Core\TestBootstrapper->install()
#14 tests/IntegrationTestBootstrapListener.php(41): Shopware\Core\TestBootstrapper->bootstrap()
#15 vendor/phpunit/phpunit/src/Framework/TestResult.php(413): Test\IntegrationTestBootstrapListener->startTestSuite(Object(PHPUnit\Framework\TestSuite))
#16 vendor/phpunit/phpunit/src/Framework/TestSuite.php(616): PHPUnit\Framework\TestResult->startTestSuite(Object(PHPUnit\Framework\TestSuite))
#17 vendor/phpunit/phpunit/src/Framework/TestSuite.php(684): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#18 vendor/phpunit/phpunit/src/TextUI/TestRunner.php(651): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#19 vendor/phpunit/phpunit/src/TextUI/Command.php(144): PHPUnit\TextUI\TestRunner->run(Object(PHPUnit\Framework\TestSuite), Array, Array, true)
#20 vendor/phpunit/phpunit/src/TextUI/Command.php(97): PHPUnit\TextUI\Command->run(Array, true)
#21 vendor/phpunit/phpunit/phpunit(107): PHPUnit\TextUI\Command::main()
@sneakyvv sneakyvv changed the title Remove script that removes installed.json Remove script that removes installed.php Jan 7, 2025
@adyen-integrations-support

Hi @sneakyvv ,

Thank you for reaching out. We’ve received your request and will look into the issue. We’ll get back to you as soon as we have more information.

Best regards

@adyen-integrations-support

Hi @sneakyvv ,

Thank you for your patience. We are in the final stages of investigating the issue and will provide you with more information shortly.

Best regards

@adyen-integrations-support

Hi @sneakyvv ,

We want to inform you that the issue you reported has been resolved. The fix will be included in the next plugin release.

We will notify you as soon as the update is available.

Thank you for your patience and understanding.

Best regards

@adyen-integrations-support

Hi @sneakyvv ,

We would like to inform you that the new release of the plugin has been released.

https://github.com/Adyen/adyen-shopware6/releases/tag/4.2.4

https://store.shopware.com/en/adyen70424242359f/adyen-payments-for-shopware-6.html?srsltid=AfmBOopTrHw-_L1Fj7SpkGar3eqgZkbUMEwCYYfUJsv0f3t4NGZC9DIN

If you encounter any issues or need further assistance, please don't hesitate to contact us.

Thank you!

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants