-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Repeat and Disk Path can be getted from config #18
Comments
Thanks for your issue, i will fix/improve most of what you mentioned, for the "C" drive label i'm aware of this issue but honestly forgot to fix that in the last update. for the part that you don't understand it's basically blacklisting python and java as they are signed binaries but they can execute code that is programmed by other people (if you know what i mean) so if the normal mode is used it will blacklist java and python as they are signed but at the same time have the possibility of executing malicious code. |
This codes using hard coded disk label, C:\ can be getted from config. Users maybe not using C: disk label or it's can be secured etc if any of them, your app will not work.
const wchar_t* Browsers[] this list is duplicated (created with same name on two place)
This lists can be getted from embedded source or a another header file like a consts.h.
i don't understand that can you explain this to me?
You can use library for that. C# has a lot of library for parsing args.
You can use Path.Combine on there
And you can use function to fix code repeating.
This variables is duplicated too is defined in 2 places (public static void Install(string Option, bool SecureBoot) and public static bool IsComponentsAvailable(string Option)). You can use class for getting this variables.
You can use ILogger (Microsoft.Extensions.Logging) interface for logging. You can use Serilog it's very easy logger with ILogger interface support.
You can get Version info from AssemblyInfo.
The text was updated successfully, but these errors were encountered: