"Filmic" tone mapping is not properly ported

[rhys-vdw]

The color grading "mode" needs to be set to "High Definition Range" for this option to be available.

[AdamFrisby]

That breaks some other options, I think the YRGB curves only work in LDR. On 13 Dec. 2018 7:15 pm, Rhys van der Waerden <[email protected]> wrote: The "mode" needs to be set to "High Definition Range" for this option to be available. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#2>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAG9efmMegE5Z1ugwtMopx0KcQ10wQ6bks5u4zQIgaJpZM4ZS5kL>.

[rhys-vdw]

Ah, cool. I guess maybe if anything it could print a warning when it finds that invalid combo.

Really I feel like Unity devs have created and be maintaining this package.

[rhys-vdw]

(It's super useful though, thanks!)

[AdamFrisby]

Yeah I'm trying to get a fix for this - I'm running into this myself. The issue is that tonemapping isn't available in LDR (it was before, -ish) --- and I can't port the YRGB curves in HDR (grrr) - I think we need to add a custom PostFX filter which does a YRGB adjustment -after- the colour grading, which allows us to use the curves again.