forked from AdaGold/solar-system
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
done #47
Open
crypt0kitty
wants to merge
15
commits into
Ada-C14:master
Choose a base branch
from
crypt0kitty:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
done #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypt0kitty
force-pushed
the
master
branch
6 times, most recently
from
February 22, 2022 07:15
718dcf1
to
b3a8804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Solar System
Reflection
| When does the
initialize
method run? What does it do? | This special method creates the @star_name and @alien_types objects.| Why do you imagine we made our instance variables readable but not writable? | Probably because we don’t want those attributes to change.
| How would your program be different if each planet was stored as a
Hash
instead of an instance of a class? | I don’t know.| How would your program be different if your
SolarSystem
class used aHash
instead of anArray
to store the list of planets? | The push/shovel method would not work to to place the aliens inside the hash. I would need to create a hash and set the symbols/keys equal to the instance variable holding alien_types.| There is a software design principle called the SRP. The Single Responsibility Principle (SRP) says that each class should be responsible for exactly one thing. Do your classes follow SRP? What responsibilities do they have? | I believe they do, the Alien_Type class deals more with creating the instance variables, or state and SolarSystem also has state but with more behavior.
| How did you organize your
require
statements? Which files neededrequire
s, and which did not? What is the pattern? | Main.rb is the only file that needs ‘requires’. It appears like main is the central location that calls methods from all classes.