Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aimee - Fire #28

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Aimee - Fire #28

wants to merge 4 commits into from

Conversation

marks214
Copy link

@marks214 marks214 commented Oct 26, 2020

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I had one error on my index.html page: Error: Bad value http://www.w3.org/1999/html for the attribute xmlns (only http://www.w3.org/1999/xhtml permitted here). From line 1, column 16; to line 2, column 52 TYPE html>. I was able to find this by deleting the xmlns in the HTML tag.
Why is it important to consider and use semantic HTML? Aside from keeping the work organized, it's really important for making the work accessible.
How did you decide to structure your CSS? My goal was to make the layout responsive. I spent a lot of time looking through codepen at examples of responsive headers and footers. I feel like I spent a lot of time with the header and footer (not really a footer, but the bottom border). Then I went back and filled in the pages with content.
What was the most challenging piece of this assignment? I felt really overwhelmed tackling a project of this magnitude. Deciding where to start was also hard. The most challenging piece of this assignment was getting grid to work on the portfolio page. It still doesn't look the way I want it too, but I spent hours trying to move the images/text around. It was really important to me to credit the images I used (copyright free), and getting the text to not do some weird wrap on the page was a struggle.
Describe one area that you gained more clarity on when completing this assignment I gained (slightly) more clarity with using grid and flex.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? No, I didn't feel ready yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant