Earth - Ana #47

anakp07 · 2020-11-17T08:13:33Z

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Describe a custom model method you wrote.	I wrote the spotlight method, which take a work as parameter and its votes and returns the piece of work with the highest votes.
Describe how you approached testing that model method. What edge cases did you come up with?	I made sure that it worked with any votes, and also tested that it would return nil if there were no votes in the system.
What are `session` and `flash`? What is the difference between them?	Sessions are used to keep track of a specific user on page (when they log-in/log-out). Flash is used to send one-time messages to user regarding status of actions.
What was one thing that you gained more clarity on through this assignment?	Testing. Its always my weak point but slowly I feel like I understand more.
What is the Heroku URL of your deployed application?	I didnt have time to deploy -- I'll try and do it even though the assignment is already turned in.

Assignment Submission: Media Ranker

Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.

Reflection

Prompt	Response
What was a custom model method you wrote? What was it responsible for doing?
Describe how you approached testing that model method. What edge cases did you come up with?
What are `session` and `flash`? What is the difference between them?
What was one thing that you gained more clarity on through this assignment?
What is the Heroku URL of your deployed application?

…ks and began to work on Works Controller methods

…orks Views

…n across pages

… buttons

…r Works

CheezItMan

Media Ranker

Functional Requirements: Manual Testing

Criteria	yes/no
Before logging in	--
1. On index page, there are at most 10 pieces of media on three lists, and a Media Spotlight	✔️, although you have a small bug, see my inline comments
2. Can go into a work's show page	✔️
3. Verify unable to vote on a work, and get a flash message	✔️
4. Can edit this work successfully, and get a flash message	✔️
5. Can go to "View all media" page and see three lists of works, sorted by vote	⚠️ the works are displayed, but not sorted by votes, see my inline notes.
6. Verify unable to create a new work when the form is empty, and details about the validation errors are visible to the user through a flash message	⚠️, Mostly right, but you're only giving 1 validation error however. You might in the future have multiple validation errors.
7. Can create a new work successfully. Note the URL for this work's show page	✔️
8. Can delete this work successfully	✔️
9. Going back to the URL of this deleted work's show page produces a 404 or some redirect behavior (and does not try to produce a broken view)	✔️
10. Verify that the "View all users" page lists no users	✔️
Log in	--
11. Logging in with a valid name changes the UI to "Logged in as" and "Logout" buttons	✔️
12. Your username is listed in "View all users" page	✔️
13. Verify that number of votes determines the Media Spotlight	✔️
14. Voting on several different pieces of media affects the "Votes" tables shown in the work's show page and the user's show page	✔️
15. Voting on the same work twice produces an error and flash message, and there is no extra vote	✔️
Log out	--
16. Logging out showed a flash message and changed the UI	✔️
17. Logging in as a new user creates a new user	✔️
18. Logging in as an already existing user has a specific flash message	✔️

Major Learning Goals/Code Review

Criteria	yes/no
1. Sees the full development cycle including deployment, and the app is deployed to Heroku	⚠️, not deployed
2. Practices full-stack development and fulfilling story requirements: the styling, look, and feel of the app is similar to the original Media Ranker	✔️, this mostly the case, you didn't have the layout on the homepage done.
3. Practices git with at least 25 small commits and meaningful commit messages	✔️

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Criteria	yes/no
4. Routes file uses `resources` for works	✔️
5. Routes file shows intention in limiting routes for voting, log-in functionality, and users	✔️
6. The homepage view, all media view, and new works view use semantic HTML	✔️
7. The homepage view, all media view, and new works view use partials when appropriate	✔️, you are using a partial, but only for the form. See my inline comments
8. The model for media (likely named `work.rb`) `has_many` votes	✔️
9. The model for media has methods to describe business logic, specifically for top ten and top media, possibly also for getting works by some category	✔️, yes, but see my inline comments for bugs
10. Some controller, likely the `ApplicationController`, has a controller filter for finding a logged in user	⚠️ No controller filters
11. Some controller, likely the `WorksController`, has a controller filter for finding a work	⚠️ No controller filters
12. The `WorksController` uses strong params	✔️
13. The `WorksController`'s code style is clean, and focused on working with requests, responses, `params`, `session`, `flash`	✔️ for the most part but you have a missing flash notice in works for update and you only show a maximum of 1 validation message...

Testing Rails Apps

Criteria	yes/no
14. There are valid fixtures files used for users, votes, and works	✔️
15. User model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
16. Vote model has tests with sections on validations (valid and invalid) and relationships (belongs to a user, belongs to a vote)	✔️
17. Work model has tests with sections on validations (valid and invalid) and relationships (has votes)	✔️
18. Work model has tests with a section on all business logic methods in the model, including their edge cases	⚠️ Yes, but you're missing some test cases

Overall Feedback

Overall Feedback	Criteria	yes/no
Yellow (Approaches Standards)	12+ in Functional Requirements: Manual Testing && 11+ in Code Review, or the instructor judges that this project needs special attention	💛

Code Style Bonus Awards

Was the code particularly impressive in code style for any of these reasons (or more...?)

Quality	Yes?
Perfect Indentation	✅
Descriptive/Readable	✅

Summary

Not bad Ana. You had some bugs, including one that stopped the homepage from loading. Take a look at my inline comments for more feedback. Things to work on include, testing more than just that something is invalid for validation errors, you want to know why it's invalid as well. You also need more through testing of model methods and controller actions. Also avoid pulling model data directly with the views, let the controller decide what data needs to get drawn and the view can work on just displaying that data.

ou did a pretty good job with testing, seems like a big improvement. You also had a lot of the functionality in place. You just had a few additional bugs. The html/css also looks pretty good overall.

Areas to work on:

Covering edge-cases in tests and testing more than just validity for validations.
Using Partial Views effectively
Review my comments on your model methods for things to avoid.
Use controller filters for things like the current user or current work.

Not a perfect solution, but not a bad one either. Definitely some growth here. Well done.

CheezItMan · 2020-11-20T00:40:58Z

config/routes.rb

+  resources :works   #Nested Routes --
+  #   resources :votes, only: [:create]
+  # end


Just curious why you didn't do this, but did the same route as a custom route on line 14?

CheezItMan · 2020-11-20T00:41:46Z

app/models/work.rb

@@ -0,0 +1,21 @@
+class Work < ApplicationRecord
+  validates :title, presence: true, uniqueness: true
+  validates :media, presence: true


Just a note that you can have another validation to make sure the category is one of a list.

CheezItMan · 2020-11-20T00:42:21Z

app/models/work.rb

+  has_many :votes
+
+  def self.spotlight
+    return nil if self.nil?


Do you mean this?

Suggested change

return nil if self.nil?

return nil if self.all.length == 0

CheezItMan · 2020-11-20T00:43:24Z

app/models/work.rb

+  end
+
+  def self.top_ten(media)
+    return nil  if self.nil?


In a class method self.nil? can never be true because the class Work is never going to be nil.

CheezItMan · 2020-11-20T00:43:31Z

app/models/work.rb

+  def self.top_ten(media)
+    return nil  if self.nil?
+
+    top_media = Work.where(media: media.to_s)


CheezItMan · 2020-11-20T01:53:37Z

app/controllers/users_controller.rb

+      if user.save
+        flash[:welcome] = "Welcome #{user.username}"
+      else
+        render :new, status: :bad_request


You should be rendering the login_form view because you don't have a new view.

CheezItMan · 2020-11-20T01:54:03Z

test/controllers/users_controller_test.rb

+    must_respond_with :success
+  end
+
+  describe "logging in" do


What about a test if the user submits an invalid user name (blank).

CheezItMan · 2020-11-20T01:55:02Z

test/models/work_test.rb

@@ -0,0 +1,84 @@
+require 'test_helper'
+require 'pry'


This is included via the Gemfile. You don't need to require it.

Suggested change

require 'pry'

CheezItMan · 2020-11-20T02:00:56Z

app/controllers/works_controller.rb

+      redirect_to work_path(@work)
+      return
+    else
+      render :edit, status: :bad_request


No flash notices?

CheezItMan · 2020-11-20T02:16:41Z

app/views/layouts/application.html.erb

+          <% if session[:user_id] %>
+          <li class = "nav-item app-header__nav_item">
+            <%= button_to "Logout", logout_path, method: :post, class: "btn btn-primary" %>
+          </li>
+        <%else %>
+            <li class = "nav-item app-header__nav_item">
+          <%=button_to "Log in", login_path, method: :get %>
+            </li>
+        <%end %>


This is something I would replace with an @user using a controller filter to find the current user. That way the view doesn't have to know anything about session.

anakp07 and others added 30 commits November 9, 2020 15:03

Initital Rails Setup

05bc37a

created Works controller

9c6301d

created a Work model

2e86f53

create the database and migrated, I also added RESTful routes for Wor…

7df1a18

…ks and began to work on Works Controller methods

seeded data

d7eb37f

Work Controller Methods for : Index, Show, New, Create, Edit and Update

1760d3e

updated the Works controller and attempted tests

0215fe2

created edit/index/new/show html.erb files for Works Views

6a99000

created an User model/controller and updated the db

6196120

CRUD for Works

d22001c

Model tests for Works validation created and passing. Also updated W…

5d120f5

…orks Views

updated the Works views, Created methods for User Controller and tests

b004156

Login tests passing for Users controller

cb654b7

created Vote model, added indirect relationships

40f918d

User controller login/logout methods and tests passing

73233d5

updated the views for homepage and index

ef801d1

updated index view with buttons

63726be

updated the index view

4fa9406

added methods to Votes controller for voting

d5b3b33

crated new Views for Users and updated them

4e80357

modified controllers

44645bd

updated index/show tables to include upvoting

09259c6

updated the Works show page to include votes

ff051f7

I updated the layout view for application by adding navigation to spa…

fd9013e

…n across pages

updated spolight medthod and implemented on homepage, and removed nav…

7f95904

… buttons

fixed minor bugs for flash messages

1efea25

minor formatting in views

306abf8

cleaned up the forms

7ff234f

updated buttons for Works show page

e6575df

cleaned up layout for Views

7c1f5d0

Ana added 13 commits November 14, 2020 23:36

updated the main homepage to include top ten

df403e5

created YML files for Works Model tests - validation tests passing fo…

b3c6f62

…r Works

adding some styling,updated homepage

137bdfb

updating styling

1f5080d

created spotlight tests and are passing

ec631ed

updated fixtures and top_ten test for works passing

d088aef

created User Model tests, login passing

5661c63

working on Votes/User tests

fb3df69

User validations/realtionships created and passing

e5825d3

Vote Model tests passing

abd7242

final tests created and passing

e9dcbfd

cleaned up files, finished project minus deployment

3d84423

updated css styling

e952a49

CheezItMan reviewed Nov 20, 2020

View reviewed changes

Ana added 4 commits November 27, 2020 16:59

Ignore .env file

6a8ec75

working on OAuth

bcf3e1d

updates

f046d33

began oAuth but on wrong file

a96dce0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Earth - Ana #47

Earth - Ana #47

anakp07 commented Nov 17, 2020 •

edited by CheezItMan

Loading

CheezItMan left a comment

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

CheezItMan Nov 20, 2020

Earth - Ana #47

Are you sure you want to change the base?

Earth - Ana #47

Conversation

anakp07 commented Nov 17, 2020 • edited by CheezItMan Loading

Media Ranker

Comprehension Questions

Assignment Submission: Media Ranker

Reflection

CheezItMan left a comment

Choose a reason for hiding this comment

Media Ranker

Functional Requirements: Manual Testing

Major Learning Goals/Code Review

Previous Rails learning, Building Complex Model Logic, DRYing up Rails Code

Testing Rails Apps

Overall Feedback

Code Style Bonus Awards

Summary

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anakp07 commented Nov 17, 2020 •

edited by CheezItMan

Loading