-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earth/Taylor #47
base: master
Are you sure you want to change the base?
Earth/Taylor #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Taylor, you have a fully functional Exquisite corpse game and you got all the tests to pass. Well done.
I did leave some notes regarding your warning messages.
@@ -6,7 +6,7 @@ const RecentSubmission = (props) => { | |||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just note there's a prop submission
that you're using here which is marked as required in propTypes, but it's not being used. Either remove it, or use the prop to get rid of the warning.
setPoemFields(emptyValues) | ||
} | ||
|
||
const inputValues = props.fields.map((field) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each item here needs a key
attribute. You can wrap the strings in a span like this:
else {
return <span key={field}> {field } </span>
}
Making sure each element in the array has a key will get rid of the warning you're seeing.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection