Water @ Hanh Solo Exquisite React Submission #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Jan 16, 2021
| @@ -3,13 +3,17 @@ import PropTypes from 'prop-types'; | |||
| import './RecentSubmission.css'; | |||
|
|
|||
| const RecentSubmission = (props) => { | |||
There was a problem hiding this comment.
Just to note the tests for this component are passing, so you didn't need to skip them.
| @@ -0,0 +1,46 @@ | |||
| const FinalPoem = (props) => { | |||
There was a problem hiding this comment.
I'm not sure what this file is for.
| @@ -3,23 +3,36 @@ import PropTypes from 'prop-types'; | |||
| import './FinalPoem.css'; | |||
|
|
|||
| const FinalPoem = (props) => { | |||
There was a problem hiding this comment.
Just a note that it looks like the tests are failing because you used different props like isRevealed instead of isSubmitted. That's why it looks like the tests are failing.
| <h3>Player Submission Form for Player #{ }</h3> | ||
|
|
||
| <form className="PlayerSubmissionForm__form" > | ||
| <h3>Player Submission Form for Player # { props.index }</h3> |
There was a problem hiding this comment.
This will cause all the tests in Game.test.js to pass.
Suggested change
| <h3>Player Submission Form for Player # { props.index }</h3> | |
| <h3>Player Submission Form for Player #{ props.index }</h3> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Exquisite React
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection